Merge lp://staging/~smspillaz/compiz-core/compiz-core.fix_978900 into lp://staging/compiz-core

Proposed by Sam Spilsbury
Status: Merged
Merged at revision: 3094
Proposed branch: lp://staging/~smspillaz/compiz-core/compiz-core.fix_978900
Merge into: lp://staging/compiz-core
Diff against target: 89 lines (+27/-24)
1 file modified
plugins/decor/src/decor.cpp (+27/-24)
To merge this branch: bzr merge lp://staging/~smspillaz/compiz-core/compiz-core.fix_978900
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
Alan Griffiths Approve
Review via email: mp+101552@code.staging.launchpad.net

Description of the change

== Problem ==

It was possible that the requested paint region would never intersect the allowed region for shadows so windows would always be painted with full shadows. (eg, shadowRegion is a region with a big hole in the middle, and requested paints fell within that hole)

== Solution ==

Intersect against the full output region when checking whether to use the offset region provided.

== Tests ==

already covered.

To post a comment you must log in.
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

LGTM

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I don't see any change with this branch. At least there are no regressions.

On both the machines I tested, dropdown menu shadows are never clipped at all (bug 659816). So I can't tell if this fix is working.

review: Abstain
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Hmm, my precise test machine is now behaving better than it was yesterday. I'll retest this...

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Now tested on precise. Sad to say that bug 978900 is not fixed. :(

review: Needs Fixing
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Actually it seems I made a mistake in my debian/patches/series. This fix is now working on precise.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches