lp://staging/~smspillaz/compiz-core/compiz-core.fix_939228

Branch merges

Propose for merging

No branches dependent on this one.

Superseded for merging into lp://staging/compiz-core/0.9.8

Daniel van Vugt: Needs Resubmitting on 2012-05-17

Alan Griffiths: Pending requested 2012-05-17

Diff: 294 lines (+221/-14)

3 files modified

src/privatescreen.h (+30/-4)
src/privatescreen/tests/test-privatescreen.cpp (+166/-0)
src/screen.cpp (+25/-10)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #755842: Non-maximized windows which sit on the border of a workspace move when called

Undecided

Invalid

Link a bug report

Related blueprints

3116. By Sam Spilsbury on 2012-05-17

Revert to the old behaviour with a note about possible bugs

3115. By Sam Spilsbury on 2012-05-15

Merged lp:compiz-core

3114. By Sam Spilsbury on 2012-05-15

Merge lp:compiz-core

3113. By Sam Spilsbury on 2012-04-27

Merge lp:compiz-core

3112. By Sam Spilsbury on 2012-04-24

s/class/struct/

3111. By Sam Spilsbury on 2012-04-24

Don't return a negative value for CompScreen::viewportForGeometry

Fix LP#939288 - If a window was partially on a viewport which was the last
one in its row or column, and we were on the viewport on the opposite side
of that row or column, compiz would work backwards to find the position
of the window (which would be negative) and return a negative viewport
position. This caused plugins like wall to behave strangely

3110. By Sam Spilsbury on 2012-04-24

Always use the asynchronous codepaths in core.
(LP: #862430) (LP: #892012) (LP: #923683) (LP: #932520)

 * CompWindow::move is now just a wrapper around CompWindow::configureXWindow
 * CompWindow::configureXWindow will always call through to moveNotify
 * moveNotify and resizeNotify are only ever called pre-request in the case of
   managed windows (SubstructureRedirectMask guaruntees they will end up in
   the right place) and post ConfigureNotify for override redirect windows
 * resizeNotify is always called post ConfigureNotify regardless of whether
   or not the window is managed or not
 * various const correctness where it made sense
 * cleaned up the whole geometry.width () + geometry.border () * 2 nonsense
 * removed priv->width and priv->height , which was just redundant data used
   for window shading and honestly, is a ticking time bomb for future
   maintainers.
 * CompWindow::syncPosition is now deprecated and a no-op
 * Removed the majority of PrivateWindow::updateFrameWindow - this function
   had a lot of redundant code which PrivateWindow::reconfigureXWindow had
   anyways - the big work there was to send synthetic ConfigureNotify events
   to ourselves to notify windows moving within frame windows that don't move
   themselves. Its safer to use reconfigureXWindow in this case and probably
   more sane too. We should look into removing the other update* functions.

3109. By Łukasz Zemczak on 2012-04-23

Reverting the introduction of bindTexture - we don't need it, since the fix
is actually a ONE LINER! Thanks Sam! (LP: #770283)

3108. By Daniel van Vugt on 2012-04-20

Tidy up PrivateScreen construction and destruction:
 - Remove a local masking a member variable.
 - Add members missing from the constructor's initialization list.
 - Free more resources, more clearly, in the destructor.

3107. By Alan Griffiths on 2012-04-20

Remove some pointless exception throwing and catching from the normal execution path.