Ubuntu
simplestreams package

Merge ~smoser/ubuntu/+source/simplestreams:bug/xenial-1686437-keystone-v3 into ubuntu/+source/simplestreams:ubuntu/xenial-devel

  1. Git
  2. lp:~smoser/ubuntu/+source/simplestreams
  3. bug/xenial-1686437-keystone-v3
  4. Merge into ubuntu/xenial-devel
Proposed by Scott Moser
Status: Needs review
Proposed branch: ~smoser/ubuntu/+source/simplestreams:bug/xenial-1686437-keystone-v3
Merge into: ubuntu/+source/simplestreams:ubuntu/xenial-devel
Diff against target: 1845 lines (+1729/-11)
10 files modified
debian/changelog (+12/-0)
debian/patches/428-do-not-require-that-hypervisor_config-be-present.patch (+23/-0)
debian/patches/433-glance-ignore-inactive-images.patch (+42/-0)
debian/patches/435-glance-refactor-for-testing.patch (+853/-0)
debian/patches/436-glance-fix-race-conditions.patch (+479/-0)
debian/patches/450-453-454-keystone-v3-support.patch (+13/-10)
debian/patches/455-nova-lxd-support-squashfs-images.patch (+230/-0)
debian/patches/460-glance-handle-v2-auth-with-sessions.patch (+33/-0)
debian/patches/series (+8/-1)
debian/patches/skip-openstack-tests-if-no-libs.patch (+36/-0)
Reviewer Review Type Date Requested Status
Rafael David Tinoco (community) Disapprove
Billy Olsen (community) Approve
Scott Moser (community) Needs Resubmitting
Felipe Reyes (community) Approve
Eric Desrochers Pending
Review via email: mp+341214@code.staging.launchpad.net

Description of the change

Openstack keystone v3 and nova-lxd squashfs SRU

Bugs:
 * bug 1578622: do not require that hypervisor_config be present.
 * bug 1583276: ignore inactive images
 * bug 1584938: glance fix race conditions in sync.
 * bug 1611987: glance-simplestreams-sync charm doesn't support keystone v3
 * bug 1686086: glance mirror and nova-lxd need support for squashfs images
 * bug 1686437: glance sync: need keystone v3 auth support
 * bug 1719879: [artful only] swift client needs to use v1 auth prior to ocata
 * bug 1728982: [artful only] openstack mirror with keystone v3 always imports new images

Merge proposals:
 - xenial: https://code.launchpad.net/~smoser/ubuntu/+source/simplestreams/+git/simplestreams/+merge/341214
 - artful: https://code.launchpad.net/~smoser/ubuntu/+source/simplestreams/+git/simplestreams/+merge/341215

PPA:
  https://launchpad.net/~smoser/+archive/ubuntu/sstream-ks3

To post a comment you must log in.
Revision history for this message
Felipe Reyes (freyes) wrote :

I tested this patch using the procedure described in the test case of bug 1686437 . To make the testing easier I created a ppa ( https://launchpad.net/~freyes/+archive/ubuntu/lp1686437 ). After installing this version running the sync up script successfully finished (connecting to keystone using v3 as verified in the logs)

# /etc/cron.daily/glance_simplestreams_sync
created c99bb337-cb1e-4873-9420-11920d911eee: auto-sync/ubuntu-trusty-14.04-amd64-server-20180404-disk1.img
created 4073e5b1-6dde-4534-8f16-5c7ea126d637: auto-sync/ubuntu-xenial-16.04-amd64-server-20180405-disk1.img

/var/log/glance-simplestreams-sync.log -> http://paste.ubuntu.com/p/7VWYsWKx4y/

review: Approve
Reply
Revision history for this message
David Ames (thedac) wrote :

Also Noting here the released version on xenial does not currently support Keystone v3 and blocks Bug #1611987.

For the record, we have been running a bzr branch @455 on serverstack (a keystone v3 cloud) for months now. So the code in simplestreams works.

Reply
Revision history for this message
Billy Olsen (billy-olsen) wrote :

The patch looks good to me, but I have a question inlined below regarding the addition of the squashfs format and the implications for syncing multiple image types into a nova lxd cloud using the ftype filter.

Reply
Revision history for this message
Scott Moser (smoser) wrote :

Billy made a good point. If we're going to pull this back we should grab revno 455 also.

review: Needs Fixing
Reply
Revision history for this message
Scott Moser (smoser) :
review: Needs Resubmitting
Reply
Revision history for this message
Scott Moser (smoser) wrote :

Billy and all,
Please re-review and ideally test the PPA upload.

Thanks.
Scott

Reply
Revision history for this message
Billy Olsen (billy-olsen) wrote :

Scott, thanks for pulling that back. Felipe is going to rebuild the package in the PPA with this latest patch pulled in. Code looks fine to me so I'll approve. I'll let Felipe comment on the testing of the PPA package.

review: Approve
Reply
Revision history for this message
Scott Moser (smoser) wrote :

an upload that I had done got into xenial for bug 1686437.
I've rebased this merge over the top of that.

Same content as before except for debian/changelog.
I've uploaded that to the ppa as 0.1.0~bzr426-0ubuntu1.4~ppa0 .
https://launchpad.net/~smoser/+archive/ubuntu/sstream-ks3/+packages

So from a code perspective, I'm pretty sure that all parties are on board with 0.1.0~bzr426-0ubuntu1.4 being uploaded... but we need to address SRU.

It now references 8 bugs, only 1 of which has an SRU template written.

Reply
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

I'm doing a -1 here according to:

https://bugs.launchpad.net/ubuntu/+source/simplestreams/+bug/1686437/comments/19

and

https://bugs.launchpad.net/ubuntu/+source/simplestreams/+bug/1686437/comments/21

And suggesting a new merge with same contents.

review: Disapprove
Reply

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches