lp://staging/~smoser/nova/milestone-proposed.lp853330

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/~hudson-openstack/nova/milestone-proposed at revision 1192

OpenStack release team: Pending requested 2011-09-20

Diff: 85 lines (+60/-1)

2 files modified

nova/virt/images.py (+59/-0)
nova/virt/libvirt/connection.py (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #837100: nova does not uncompress qcow compressed images	Wishlist	Fix Released
Bug #837102: nova writes libvirt xml 'driver_type' based only on FLAGS.use_cow_images	Low	Fix Released
Bug #853330: qcow format could expose host filesystem information	High	Fix Released

Link a bug report

Related blueprints

1192. By Scott Moser on 2011-09-20

clean up temp files if an ImageUnacceptable is going to be raised

1191. By Scott Moser on 2011-09-20

do not use '_' in arguments 'user_id' and 'project_id'

This responds to Soren's comment:
 * Calling the final two arguments to fetch_to_raw "_user_id" and "_project_id"
   suggests they're not used, while in fact they're passed on to fetch (which
   may or may not ignore them).

1190. By Scott Moser on 2011-09-20

use 'env' rather than same function with 'sh -c', as 'env' is used other places

env is a reasonable dependency. previously I avoided it, but I think this
looks more readable to many people without shell experience.

1189. By Scott Moser on 2011-09-20

set LC_ALL and LANG=C when invoking qemu-img so output is not locale dependent

1188. By Scott Moser on 2011-09-20

add missing local variable, fix call to gettext

1187. By Scott Moser on 2011-09-20

merge with milestone at revno 1184

1186. By Scott Moser on 2011-09-20

use dictionary format for exception message, drop "Dangerous!" comment

1185. By Scott Moser on 2011-09-19

use '_(' for exception messages

1184. By Scott Moser on 2011-09-19

convert images that are not 'raw' to 'raw' during caching to node

This uses 'qemu-img' to convert images that are not 'raw' to be 'raw'.
By doing so, it
 a.) refuses to run uploaded images that have a backing image reference
     (LP: #853330, CVE-2011-3147)
 b.) ensures that when FLAGS.use_cow_images is False, and the libvirt
     xml written specifies 'driver_type="raw"' that the disk referenced
     is also raw format. (LP: #837102)
 c.) removes compression that might be present to avoid cpu bottlenecks
     (LP: #837100)

It does have the negative side affect of using more space in the case where
the user uploaded a qcow2 (or other advanced image format) that could have
been used directly by the hypervisor. That could, later, be remedied by
another 'qemu-img convert' being done to the "preferred" format of the
hypervisor.

1183. By Scott Moser on 2011-09-19

create disk.local the same way ephemerals are created (LP: #851145)

If the user did not specify '--block-device-mapping /dev/vdb=ephemeral0', then
then the first non-root device would end up being created differently then
if they had. It would not have a filesystem on it.

This makes 'local_gb' in the libvirt connection created the same way that
it would be if it were named ephemeral0.