Merge lp://staging/~smoser/maas-images/trunk.use-unshare into lp://staging/maas-images
Proposed by
Scott Moser
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 365 | ||||
| Proposed branch: | lp://staging/~smoser/maas-images/trunk.use-unshare | ||||
| Merge into: | lp://staging/maas-images | ||||
| Diff against target: |
96 lines (+31/-2) 4 files modified
bin/kpack-from-image (+2/-0) bin/maas-cloudimg2ephemeral (+2/-0) bin/maas-qcow2targz (+3/-2) bin/unshare-pidns (+24/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~smoser/maas-images/trunk.use-unshare | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Blake Rouse (community) | Approve | ||
|
Review via email:
|
|||
Commit message
When using chroot unshare pid namespace when possible.
This adds a helper 'unshare-pidns' that invokes unshare --pid --fork
if it is available. It will not fail when it is not available though
as it is not expected to be present on trusty and precise.
The reason for this is so any unexpected children of the chroot process
will be killed allowing unmount to succeed.
See LP: #1645680 for example of such issues.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good.