lp://staging/~smoser/editmoin/bug610154

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/editmoin

Gustavo Niemeyer: Approve on 2010-09-15

Diff: 14 lines (+3/-1)

1 file modified

editmoin (+3/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #610154: cannot pass arguments to EDITOR command

Undecided

Fix Released

Link a bug report

Related blueprints

31. By Scott Moser on 2010-07-26

remove debug '-x' option to sh

30. By Scott Moser on 2010-07-26

allow arguments to be present in EDITOR variable (ie 'gvim -f') LP: #610154

call the editor through a shell, this allows for shell interpretation of
the contents of "EDITOR", and thus supports:
   EDITOR="gvim -f"
or
   EDITOR="vim"

The fallout of doing this is that a binary named:
   "/usr/bin/my editor"

would now have to be called as:
   EDITOR="/usr/bin/my\ editor"

An alternative solution might look like this:
- subprocess.call([editor, filename])
+ cmd=editor.split(' ')
+ cmd.append(filename)
+ subprocess.call(cmd)

That would just split the EDITOR command on white space rather than
letting the shell handle that split. I personally prefer letting shell
handle the split as it is a extremely well defined handling.

Ie, I knew that one level of shell interpretation would be escaped with
the above '\' in "my\ editor". With a simple split in python of the
above, it would be difficult or impossible to invoke an executable with
a space in the path.

29. By Gustavo Niemeyer on 2010-06-19

A few additional updates in the manual page.

28. By Gustavo Niemeyer on 2010-06-19

Update MoinMoin URL in setup.py.

27. By Gustavo Niemeyer on 2010-06-19

- Introduced support for direct authentication with newer moins,
  inspired by Reimar Bauer.
- Introduced support for the ~/.moin_users file, to configure usernames
  on multiple sites.
- Shortcutting also checks ~/.moin_users now.
- Added support for textcha questions and answers.
- Updated manual page.

26. By Gustavo Niemeyer on 2008-03-05

Removing debian directory, as requested by Martin.

25. By Gustavo Niemeyer on 2008-03-05

Adding editmoin.1 to MANIFEST.in file, as pointed out by Neal Becker.

24. By Gustavo Niemeyer on 2008-03-04

Updated MANIFEST.in file.

23. By Gustavo Niemeyer on 2008-03-04

Preparing to release 1.10.

22. By Gustavo Niemeyer on 2008-03-04

- Implemented Moin 1.6+ syntax file.
- editmoin will now present a Syntax header at the top to enable
  editors to pick the right syntax.