Merge lp://staging/~smoser/curtin/trunk.trusty-raid5bcache into lp://staging/~curtin-dev/curtin/trunk
Status: | Merged |
---|---|
Merged at revision: | 317 |
Proposed branch: | lp://staging/~smoser/curtin/trunk.trusty-raid5bcache |
Merge into: | lp://staging/~curtin-dev/curtin/trunk |
Diff against target: |
11 lines (+4/-0) 1 file modified
tests/vmtests/test_raid5_bcache.py (+4/-0) |
To merge this branch: | bzr merge lp://staging/~smoser/curtin/trunk.trusty-raid5bcache |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Server Team CI bot | continuous-integration | Approve | |
curtin developers | Pending | ||
Review via email:
|
Commit message
vmtest: do not expect sda-part2 to exist in /dev/disk/by-dname on trusty
This never worked, but we did not see failure before because of a
test case never properly executing.
Description of the change
trunk will now reliably fail like this:
=======
FAIL: test_dname (vmtests.
-------
Traceback (most recent call last):
File "/opt/fast/
self.
AssertionError: 'sda-part2' not found in ['bcache0', 'md0']
The reason for that is not actually regression, but fix of the test. my change to tests/vmtests/
def test_dname(self):
- if (os.path.
- self.disk_to_check is not None):
- with open(os.
+ fpath = os.path.
+ if (os.path.
+ with open(fpath, "r") as fp:
for diskname, part in self.disk_
if part is not 0:
Previously the test was not actually doing anything as self.td.mnt did not have a trailing '/', resulting in os.path.exists always returning false. So this test would always pass but never did what was desired.
PASSED: Continuous integration, rev:316 /server- team-jenkins. canonical. com/job/ curtin- ci/37/ /server- team-jenkins. canonical. com/job/ generic- update- mp/35/console
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild: /server- team-jenkins. canonical. com/job/ curtin- ci/37/rebuild
https:/