Merge ~slyon/ubuntu/+source/systemd:slyon/resolved-segfault-root-cause into ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-hirsute

Proposed by Lukas Märdian
Status: Needs review
Proposed branch: ~slyon/ubuntu/+source/systemd:slyon/resolved-segfault-root-cause
Merge into: ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-hirsute
Diff against target: 331 lines (+239/-17)
4 files modified
debian/changelog (+11/-0)
debian/patches/resolved-disable-event-sources-before-unreffing-them.patch (+22/-16)
debian/patches/resolved-fix-braino-with-reference-counting-and-linked-li.patch (+204/-0)
debian/patches/series (+2/-1)
Reviewer Review Type Date Requested Status
Dan Streetman Pending
Review via email: mp+408886@code.staging.launchpad.net

Description of the change

resolved: cherry-pick upstream commits to fix segfault (LP: #1934221)

Replace d/p/lp1934221-resolved-disable-event-sources-before-unreffing-them.patch with upstream commit from systemd v247-stable branch (d/p/resolved-disable-event-sources-before-unreffing-them.patch) and add d/p/resolved-fix-braino-with-reference-counting-and-linked-li.patch

The additional patch is a fixup of an already included (in systemd-stable v247.3) patch "resolved: use reference counting for DnsQueryCandidate objects" and should help with avoiding the query related segfaults.
There haven't been any other relevant commits to resolved-dns-query.c in v247-stable nor upstream/master.

I have not been able to reproduce this problem locally as it happens only sporadically. Applying this fixup and observing if this crash does still happen in Hirsute should be a good measure of success, before backporting the changes to Focal:
https://errors.ubuntu.com/problem/c4e5be3f1c7af9483993c7e6007b9325ab5b78cd

To post a comment you must log in.
Revision history for this message
Lukas Märdian (slyon) wrote :
Revision history for this message
Lukas Märdian (slyon) wrote :

I'm also working with the original bug reporter, trying to get confirmation about this issue being fixed in a PPA: https://launchpad.net/~slyon/+archive/ubuntu/lp1934221/+packages

https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1934221

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches