Merge ~slyon/network-manager:skip-unknown-connections into network-manager:ubuntu/master

Proposed by Lukas Märdian
Status: Merged
Merged at revision: d9c6824d03a57b1225612e13b3544cc365492e9e
Proposed branch: ~slyon/network-manager:skip-unknown-connections
Merge into: network-manager:ubuntu/master
Diff against target: 30 lines (+9/-1)
2 files modified
debian/changelog (+6/-0)
debian/network-manager.postinst (+3/-1)
Reviewer Review Type Date Requested Status
Steve Langasek Abstain
Sebastien Bacher Approve
Danilo Egea Gondolfo (community) Approve
Review via email: mp+453731@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Danilo Egea Gondolfo (danilogondolfo) wrote :

Looks OK to me.

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

wfm

review: Approve
Revision history for this message
Steve Langasek (vorlon) wrote :

One minor suggestion on the code style. Otherwise I don't have any opinion on whether this is a correct solution

Revision history for this message
Steve Langasek (vorlon) :
review: Abstain
Revision history for this message
Lukas Märdian (slyon) wrote :

Thank you. I adopted it according to Steve's comment and pushed to the `ubuntu/master` branch, to be included when the archive re-opens. Will prepare for SRU in a mantic branch.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: