Merge lp://staging/~sleepsonthefloor/nova/lp742650 into lp://staging/~hudson-openstack/nova/trunk

Proposed by Anthony Young
Status: Merged
Approved by: Soren Hansen
Approved revision: 911
Merged at revision: 916
Proposed branch: lp://staging/~sleepsonthefloor/nova/lp742650
Merge into: lp://staging/~hudson-openstack/nova/trunk
Diff against target: 39 lines (+9/-10)
1 file modified
bin/nova-ajax-console-proxy (+9/-10)
To merge this branch: bzr merge lp://staging/~sleepsonthefloor/nova/lp742650
Reviewer Review Type Date Requested Status
Soren Hansen (community) Approve
Devin Carlen (community) Approve
Review via email: mp+55449@code.staging.launchpad.net

Description of the change

TopicAdapterConsumer uses a different callback model than TopicConsumer. This patch updates the console proxy to use this pattern.

Without this patch, nova-ajax-console proxy will generate an error every time an auth token is cast to it, and hence it won't work.

To post a comment you must log in.
Revision history for this message
Devin Carlen (devcamcar) wrote :

lgtm

review: Approve
Revision history for this message
Soren Hansen (soren) wrote :

Awesome, I was just wondering why this wasn't working :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.