Unity Asset Pool

Merge lp://staging/~sladen/unity-asset-pool/unity-asset-pool-icons-lp745555 into lp://staging/unity-asset-pool

  1. unity-asset-pool-icons-lp745555
  2. Merge into trunk
Proposed by Paul Sladen
Status: Merged
Merged at revision: 50
Proposed branch: lp://staging/~sladen/unity-asset-pool/unity-asset-pool-icons-lp745555
Merge into: lp://staging/unity-asset-pool
Diff against target: 42 lines (+11/-1)
1 file modified
unity-icon-theme/index.theme (+11/-1)
To merge this branch: bzr merge lp://staging/~sladen/unity-asset-pool/unity-asset-pool-icons-lp745555
Reviewer Review Type Date Requested Status
Paul Sladen (community) Needs Resubmitting
Didier Roche-Tolomelli Pending
Review via email: mp+57307@code.staging.launchpad.net

This proposal supersedes a proposal from 2011-04-11.

Description of the change

Glad the extra rename meta-data was useful rather than a delete/create :)

Resubmitting per-IRC since that's what's available.

Didrocks: I should note that in the massive-asset-dump there were 62 icons with no hint as to which ones actually needed replacing. If (in your opinion) the change between before and after is indistinguishable/imperceivable then there's a the opinion not to ship it on the basis that no "diff" of the priority changes was provided with the dump.

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote : Posted in a previous version of this proposal

renamed file 'unity-icon-theme/places/svg/group-mostused.svg' => 'unity-icon-theme/places/22/group-mostused.png'

All that will make a lot of changes in the places, change which should be coordinated and such.

Please, repropose a merge for the other contents (launcher/tile_arrow.png, panel/divider.png, unity-icon-theme/apps/48/workspace-switcher.png and unity-icon-theme/places/48/user-trash*) without those changes

review: Disapprove
lp://staging/~sladen/unity-asset-pool/unity-asset-pool-icons-lp745555 updated
51. By Paul Sladen

revert -r49 unity-icon-theme/places/svg/group-*.svg per IRC

Revision history for this message
Paul Sladen (sladen) :
review: Disapprove
Revision history for this message
Paul Sladen (sladen) wrote :

bzr revert -r49 unity-icon-theme/places/svg/group-*.svg per IRC

review: Needs Resubmitting
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote : Posted in a previous version of this proposal

ok, launchpad is laggy to refresh the merge, taking the branch, all looks good now :) thanks Paul!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: