Merge lp://staging/~skeuchel/terminator/hyper-modifier into lp://staging/terminator/trunk
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merge reported by: | Stephen Boddy | ||||
| Merged at revision: | not available | ||||
| Proposed branch: | lp://staging/~skeuchel/terminator/hyper-modifier | ||||
| Merge into: | lp://staging/terminator/trunk | ||||
| Diff against target: |
11 lines (+1/-0) 1 file modified
terminatorlib/keybindings.py (+1/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~skeuchel/terminator/hyper-modifier | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Stephen Boddy | Approve | ||
|
Review via email:
|
|||
Description of the change
This patch add hyper to the list of recognized modifiers. To test:
1. Map e.g. CapsLock to Hyper_L
$ xmodmap -e 'clear lock'
$ xmodmap -e 'keycode 66 = Hyper_L'
$ xmodmap -e 'add mod3 = Hyper_L'
2. Assign a keybinding using the Hyper modifier.
3. Restart terminator
3.1 Before the patch you get
$ /usr/bin/terminator -d 2>&1 | grep keybind
ConfigBase::load: ConfigBase::load: Processing section: keybindings
keybindings.
And terminator's preferences show the keybinding as 'Disabled'.
3.2 After the patch you only get the first info
$ terminator -d 2>&1 | grep keybind
ConfigBase::load: ConfigBase::load: Processing section: keybindings
And the preferences show the keybindings just fine.
Approved. However it was added to the gtk3 branch, not the old gtk2 trunk.