This is my branch to improve the release experience. lp:~sinzui/launchpad/release-love Diff size: 242 Launchpad bug: https://bugs.launchpad.net/bugs/403554 https://bugs.launchpad.net/bugs/510984 https://bugs.launchpad.net/bugs/341687 https://bugs.launchpad.net/bugs/386584 https://bugs.launchpad.net/bugs/386586 Test command: ./bin/test -vv \ -t malone-karma \ -t productrelease-views \ -t milestone \ -t xx-productrelease-basics \ -t xx-productrelease-view Pre-implementation: No one. I really wanted to do this. Target release: 10.01 Improve the release experience ------------------------------ This branch fixes several small bugs that irk me when I make releases. * Project drivers do not get credit for setting a bug to triaged, but users get credit for setting a bug to confirmed. * When creating a release, all the fix committed bugs should be set to fix released. * The release manager should not get the karma for marking bugs fix released when they are assigned to someone. * The release manager should not see a warning about a deactivate milestone because 1) the form asked him if he wanted to keep it active and 2) the milestone page clearly and prominently show the state, * Do not show the date expected when showing the date released. This does not mean much for launchpad, but it means a lot for milestones that are not time-boxed. Rules ----- * Treated triaged as confirmed in karma rules. * Add a rule to award karma to the assignee of a fix released bug. * Set fix committed bugs to fix released when a milestone creates a release. * Do not show a warning about a deactivated milestone when the user can see the status in both for the form and the page. * Do not show the date expect when a milestone has a date released. QA -- * Triage a bug. * Verify that you are awarded bugaccepted karma on you karma activity. * Mark a bug that is assigned to someone else as fix committed. * Verify that you are NOT awarded bugfixed karma on you karma activity. * Verify that the other user is awarded bugfixed karma on his karma activity page. * Release a milestone with bugs fix committed. * Verify that the milestones are fixed released. * When creating a release, verify that you do not see an info notification that the milestone was deactivated because you told Launchpad to deactivate it * Visit https://edge.launchpad.net/libcpuinfo/trunk/0.0.1 * Verify that the Expected field is not displayed. Lint ---- Linting changed files: lib/canonical/launchpad/subscribers/karma.py lib/lp/bugs/doc/malone-karma.txt lib/lp/registry/browser/productrelease.py lib/lp/registry/browser/tests/productrelease-views.txt lib/lp/registry/doc/milestone.txt lib/lp/registry/model/milestone.py lib/lp/registry/stories/productrelease/xx-productrelease-basics.txt lib/lp/registry/stories/productrelease/xx-productrelease-view.txt lib/lp/registry/templates/milestone-index.pt Test ---- * lib/lp/bugs/doc/malone-karma.txt * lib/lp/registry/browser/tests/productrelease-views.txt * lib/lp/registry/doc/milestone.txt * lib/lp/registry/stories/productrelease/xx-productrelease-basics.txt * lib/lp/registry/stories/productrelease/xx-productrelease-view.txt Implementation -------------- * lib/canonical/launchpad/subscribers/karma.py * lib/lp/registry/browser/productrelease.py * lib/lp/registry/model/milestone.py * lib/lp/registry/templates/milestone-index.pt