Merge lp://staging/~sinzui/launchpad/over-and-over into lp://staging/launchpad
Status: | Merged |
---|---|
Approved by: | Graham Binns |
Approved revision: | no longer in the source branch. |
Merged at revision: | 10916 |
Proposed branch: | lp://staging/~sinzui/launchpad/over-and-over |
Merge into: | lp://staging/launchpad |
Diff against target: |
124 lines (+24/-8) 6 files modified
lib/lp/registry/browser/distroseries.py (+5/-2) lib/lp/registry/browser/tests/distroseries-views.txt (+10/-0) lib/lp/registry/interfaces/product.py (+4/-1) lib/lp/registry/stories/product/xx-product-edit.txt (+2/-2) lib/lp/registry/stories/productseries/xx-productseries-series.txt (+1/-1) lib/lp/registry/templates/productseries-macros.pt (+2/-2) |
To merge this branch: | bzr merge lp://staging/~sinzui/launchpad/over-and-over |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Approve | |
Review via email: mp+25964@code.staging.launchpad.net |
Description of the change
This is my branch to fix some trivial registry issues.
lp:~sinzui/launchpad/over-and-over
Diff size: 126
Launchpad bug: https:/
https:/
https:/
Test command: ./bin/test -vv \
-t distroseries-views -t xx-product-edit -t xx-productserie
Pre-
Target release: 10.05
Fix some trivial registry issues
-------
Bug 253534 ["focus of development" incorrectly capitalised]
The development focus series of a project has its status shown as "focus
of development". Of course, it is actually "Active Development". It could
at least be properly capitalised and maybe have a star like branches do.
The darkened background makes it less obvious - it looks like a heading.
Bug 274493 [Development focus isn't explained usefully]
The form control description is does not explain that the development
focus (changes what "bzr branch lp:project-name" does
Bug 559013 [the 'status' edit button on eg Lucid takes you to the wrong page]
The link is right, the view is ignoring that the person is an admin.
Rules
-----
Bug 253534 ["focus of development" incorrectly capitalised]
* Use "Focus of Development"
Bug 274493 [Development focus isn't explained usefully]
* Updated the text to explain the affect of changing the development
focus.
Bug 559013 [the 'status' edit button on eg Lucid takes you to the wrong page]
* Add admins to the clause the adds the status field.
QA
--
Bug 253534 ["focus of development" incorrectly capitalised]
* Visit https:/
* Verify the case is correct.
Bug 274493 [Development focus isn't explained usefully]
* Visit https:/
* Verify that the Development focus field explains that changing the
series changes lp:<project>
Bug 559013 [the 'status' edit button on eg Lucid takes you to the wrong page]
* As an admin, visit https:/
* Verify you can see the status field.
Lint
----
* lib/lp/
* lib/lp/
* lib/lp/
* lib/lp/
* lib/lp/
* lib/lp/
Test
----
* lib/lp/
* Added a test to verify that admins see the status field on
* lib/lp/
* Updated the test to show the correct case.
* lib/lp/
* Updated the test to show the correct case.
Implementation
--------------
* lib/lp/
* Changed the status field guard to "admin or IDerivativeDist
* lib/lp/
* Removed the text of the development focus field to explain that the
value sets lp:<project>
* lib/lp/
* Fixed the case of "Focus of Development".