Merge lp://staging/~sinzui/launchpad/over-and-over into lp://staging/launchpad

Proposed by Curtis Hovey
Status: Merged
Approved by: Graham Binns
Approved revision: no longer in the source branch.
Merged at revision: 10916
Proposed branch: lp://staging/~sinzui/launchpad/over-and-over
Merge into: lp://staging/launchpad
Diff against target: 124 lines (+24/-8)
6 files modified
lib/lp/registry/browser/distroseries.py (+5/-2)
lib/lp/registry/browser/tests/distroseries-views.txt (+10/-0)
lib/lp/registry/interfaces/product.py (+4/-1)
lib/lp/registry/stories/product/xx-product-edit.txt (+2/-2)
lib/lp/registry/stories/productseries/xx-productseries-series.txt (+1/-1)
lib/lp/registry/templates/productseries-macros.pt (+2/-2)
To merge this branch: bzr merge lp://staging/~sinzui/launchpad/over-and-over
Reviewer Review Type Date Requested Status
Graham Binns (community) code Approve
Review via email: mp+25964@code.staging.launchpad.net

Description of the change

This is my branch to fix some trivial registry issues.

    lp:~sinzui/launchpad/over-and-over
    Diff size: 126
    Launchpad bug: https://bugs.launchpad.net/bugs/253534
                   https://bugs.launchpad.net/bugs/274493
                   https://bugs.launchpad.net/bugs/559013
    Test command: ./bin/test -vv \
        -t distroseries-views -t xx-product-edit -t xx-productseries-series
    Pre-implementation: no one
    Target release: 10.05

Fix some trivial registry issues
--------------------------------

Bug 253534 ["focus of development" incorrectly capitalised]
    The development focus series of a project has its status shown as "focus
    of development". Of course, it is actually "Active Development". It could
    at least be properly capitalised and maybe have a star like branches do.
    The darkened background makes it less obvious - it looks like a heading.

Bug 274493 [Development focus isn't explained usefully]
    The form control description is does not explain that the development
    focus (changes what "bzr branch lp:project-name" does

Bug 559013 [the 'status' edit button on eg Lucid takes you to the wrong page]
    The link is right, the view is ignoring that the person is an admin.

Rules
-----

Bug 253534 ["focus of development" incorrectly capitalised]
    * Use "Focus of Development"

Bug 274493 [Development focus isn't explained usefully]
    * Updated the text to explain the affect of changing the development
      focus.

Bug 559013 [the 'status' edit button on eg Lucid takes you to the wrong page]
    * Add admins to the clause the adds the status field.

QA
--

Bug 253534 ["focus of development" incorrectly capitalised]
    * Visit https://edge.launchpad.net/launchpad/+series
    * Verify the case is correct.

Bug 274493 [Development focus isn't explained usefully]
    * Visit https://edge.launchpad.net/launchpad/+edit
    * Verify that the Development focus field explains that changing the
      series changes lp:<project>

Bug 559013 [the 'status' edit button on eg Lucid takes you to the wrong page]
    * As an admin, visit https://edge.launchpad.net/ubuntu/maverick
    * Verify you can see the status field.

Lint
----

    * lib/lp/registry/browser/distroseries.py
    * lib/lp/registry/browser/tests/distroseries-views.txt
    * lib/lp/registry/interfaces/product.py
    * lib/lp/registry/stories/product/xx-product-edit.txt
    * lib/lp/registry/stories/productseries/xx-productseries-series.txt
    * lib/lp/registry/templates/productseries-macros.pt

Test
----

    * lib/lp/registry/browser/tests/distroseries-views.txt
      * Added a test to verify that admins see the status field on
        distroseries+edit.
    * lib/lp/registry/stories/product/xx-product-edit.txt
      * Updated the test to show the correct case.
    * lib/lp/registry/stories/productseries/xx-productseries-series.txt
      * Updated the test to show the correct case.

Implementation
--------------

    * lib/lp/registry/browser/distroseries.py
      * Changed the status field guard to "admin or IDerivativeDistribution".
    * lib/lp/registry/interfaces/product.py
      * Removed the text of the development focus field to explain that the
        value sets lp:<project>
    * lib/lp/registry/templates/productseries-macros.pt
      * Fixed the case of "Focus of Development".

To post a comment you must log in.
Revision history for this message
Graham Binns (gmb) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.