Merge lp://staging/~sinzui/launchpad/merge-person-notifications-0 into lp://staging/launchpad

Proposed by Curtis Hovey
Status: Merged
Approved by: Curtis Hovey
Approved revision: no longer in the source branch.
Merged at revision: 12578
Proposed branch: lp://staging/~sinzui/launchpad/merge-person-notifications-0
Merge into: lp://staging/launchpad
Diff against target: 0 lines
To merge this branch: bzr merge lp://staging/~sinzui/launchpad/merge-person-notifications-0
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+52904@code.staging.launchpad.net

Description of the change

Migrate registry notifcations to lp.registry.

    Launchpad bug: https://bugs.launchpad.net/bugs/732059
    Pre-implementation: no one
    Test command: ./bin/test -vv \
      -t test_teammembership -t test_personnotification
      -t mailinglist-enail-notification -t message-holds
      -t person-notification -t teammembership-email-notification
      -t user-to-user -t TestMMCfgLaunchpadConfigTestCase

Most of the email templates in canonical.launchpad are used exclusively by
lp.registry. These files should be moved before one is edited or added, such
as when working on bug 728471.

--------------------------------------------------------------------

RULES

    * Extract the registry mail notifications to lp.registry.mail.notification
    * Move the templates to lp.registry.emailtemplates
    * Update the calls to get_email_template() to pass app='registry'
    * ADDENDUM: Moved the mailman email template to lp.services.mailman

QA

    None. This is a pure refactoring

LINT

    lib/canonical/launchpad/mailnotification.py
    lib/lp/registry/configure.zcml
    lib/lp/registry/mail/
    lib/lp/registry/browser/person.py
    lib/lp/registry/browser/product.py
    lib/lp/registry/mail/__init__.py
    lib/lp/registry/mail/notification.py
    lib/lp/registry/model/distributionmirror.py
    lib/lp/registry/model/person.py
    lib/lp/registry/model/persontransferjob.py
    lib/lp/registry/model/teammembership.py
    lib/lp/services/mailman/monkeypatches/__init__.py
    lib/lp/services/mailman/monkeypatches/emailtemplates/

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Self approve because this is a mechanical refactoring. The real changes will come in my next branch.

review: Approve (code)

Preview Diff

Empty