Merge lp://staging/~sinzui/launchpad/mental-health-0 into lp://staging/launchpad

Proposed by Curtis Hovey
Status: Merged
Approved by: Brad Crittenden
Approved revision: no longer in the source branch.
Merged at revision: 10951
Proposed branch: lp://staging/~sinzui/launchpad/mental-health-0
Merge into: lp://staging/launchpad
Diff against target: 316 lines (+80/-31)
14 files modified
lib/canonical/launchpad/webapp/configure.zcml (+6/-0)
lib/canonical/launchpad/webapp/tales.py (+11/-0)
lib/lp/bugs/stories/bug-tags/xx-official-bug-tags.txt (+2/-3)
lib/lp/bugs/stories/guided-filebug/xx-distro-guided-filebug-tags.txt (+4/-4)
lib/lp/bugs/stories/guided-filebug/xx-filebug-tags.txt (+5/-5)
lib/lp/bugs/templates/bugtask-macros-tableview.pt (+3/-2)
lib/lp/bugs/tests/bug.py (+8/-0)
lib/lp/registry/browser/person.py (+3/-3)
lib/lp/registry/browser/product.py (+7/-1)
lib/lp/registry/browser/tests/test_product.py (+9/-0)
lib/lp/registry/stories/mailinglists/subscriptions.txt (+1/-1)
lib/lp/registry/templates/team-mailinglist-subscribers.pt (+7/-2)
lib/lp/registry/templates/team-portlet-mailinglist.pt (+13/-9)
lib/lp/soyuz/templates/build-index.pt (+1/-1)
To merge this branch: bzr merge lp://staging/~sinzui/launchpad/mental-health-0
Reviewer Review Type Date Requested Status
Brad Crittenden (community) Approve
Review via email: mp+26832@code.staging.launchpad.net

Description of the change

This is my branch to fix some trivial issues to recover my mind.

    lp:~sinzui/launchpad/mental-health-0
    Diff size: 265
    Launchpad bug: https://bugs.launchpad.net/bugs/588820
                   https://bugs.launchpad.net/bugs/583311
                   https://bugs.launchpad.net/bugs/401923
    Test command: ./bin/test -vv \
        -t TestProductLicenseMixin -t stories/mailinglists/subscriptions
        -t xx-official-bug-tags.txt -t xx-distro-guided-filebug-tags.txt
        -t xx-filebug-tags.txt
    Pre-implementation: no one.
    Target release: 10.06

Fix some trivial issues to recover my mind
-------------------------------------------

Bug #588820 [licence emails leave a bad timestamp on the whiteboard]
    The whiteboard date is wrong, minutes are shown where a month is
    expected.

Bug #583311 [Better wording for team mailing list section]
    The wording implies that the team does not have a mailing list, but
    the team may have one hosted else where, like lists.ubuntu.com/

Bug #401923 [advanced search pop up help for tags doesn't work if you are
    in a different domain]
    Help fails to load on
    https://edge.launchpad.net/launchpad/+bugs?advanced=1
    because the bugs domain was not specified in the help link. Help is
    specific to domains, so the domain must be used if the help is used
    by more than one domain.

Rules
-----

Bug #588820 [licence emails leave a bad timestamp on the whiteboard]
    * Extract the date formatting rule so that it can be tested.
    * use mm instead of MM to insert the month.

Bug #583311 [Better wording for team mailing list section]
    * Use "This team does not use Launchpad to host a mailing list." to
      make it clear to used who view the team page that Launchpad does
      not know about the mailing list. We still want to show a message so that
      users do not search Launchpad for information that does not exist. This
      may prevent novice admins from trying to register an ubuntu list from
      Launchpad (We see this mistake every few months.)

Bug #401923 [advanced search pop up help for tags doesn't work if you are
    in a different domain]
    * Extract the common bug tag testing pattern to a test helper so that
      only one rule needs updating for the url change.
    * Include the bugs domain in the tags help link. Tags is the only
      part of the form that uses a help link, but it the bugs rooturl should
      be available to any part of the form.

QA
--

Bug #588820 [license emails leave a bad timestamp on the whiteboard]
    * During project review
    * Verify that the "I don't know" projects have a sane date.

Bug #583311 [Better wording for team mailing list section]
    * Visit https://launchpad.net/~ubuntu-l10n-es
    * Verify the page states:
      "This team does not use Launchpad to host a mailing list."

Bug #401923 [advanced search pop up help for tags doesn't work if you are
    in a different domain]
    * Visit https://edge.launchpad.net/launchpad/+bugs?advanced=1
    * Verify that the tag help displays when accessed.

Lint
----

Linting changed files:
  lib/lp/bugs/stories/bug-tags/xx-official-bug-tags.txt
  lib/lp/bugs/stories/guided-filebug/xx-distro-guided-filebug-tags.txt
  lib/lp/bugs/stories/guided-filebug/xx-filebug-tags.txt
  lib/lp/bugs/templates/bugtask-macros-tableview.pt
  lib/lp/bugs/tests/bug.py
  lib/lp/registry/browser/person.py
  lib/lp/registry/browser/product.py
  lib/lp/registry/browser/tests/test_product.py
  lib/lp/registry/stories/mailinglists/subscriptions.txt
  lib/lp/registry/templates/team-mailinglist-subscribers.pt
  lib/lp/registry/templates/team-portlet-mailinglist.pt

Test
----

    * lib/lp/bugs/stories/bug-tags/xx-official-bug-tags.txt
    * lib/lp/bugs/stories/guided-filebug/xx-distro-guided-filebug-tags.txt
    * lib/lp/bugs/stories/guided-filebug/xx-filebug-tags.txt
      * Extracted the common pattern to a helper. Updated two tests to
        show that the tag are unofficial.

    * lib/lp/registry/browser/tests/test_product.py
      * Added a test to verify the date is formatted with the month.

    * lib/lp/registry/stories/mailinglists/subscriptions.txt
      * Updated the test to verify that that the team does not have
        a Launchpad hosted mailing list.

Implementation
--------------

    * lib/lp/bugs/templates/bugtask-macros-tableview.pt
      * Added the bugs vhost to the tag help link.

    * lib/lp/bugs/tests/bug.py
      * Added a new test helper based on the common pattern in story tests.
        Changed the help link guard to work with the bugs domain.

    * lib/lp/registry/browser/person.py
    * lib/lp/registry/templates/team-mailinglist-subscribers.pt
    * lib/lp/registry/templates/team-portlet-mailinglist.pt
      * Clarified the no mailing list message.

    * lib/lp/registry/browser/product.py
      * Extracted the date format rules to a testable method, then fixed
        the format string to use the month.

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) wrote :

You are my hero. Very nice fixes all.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.