Merge lp://staging/~sinzui/launchpad/cache-country-mirrors-0 into lp://staging/launchpad
| Status: | Merged |
|---|---|
| Approved by: | Brad Crittenden |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~sinzui/launchpad/cache-country-mirrors-0 |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
44 lines (+9/-2) 2 files modified
lib/lp/registry/doc/cache-country-mirrors.txt (+6/-1) scripts/cache-country-mirrors.py (+3/-1) |
| To merge this branch: | bzr merge lp://staging/~sinzui/launchpad/cache-country-mirrors-0 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brad Crittenden (community) | code | Approve | |
|
Review via email:
|
|||
Description of the change
This is my branch to make cache-country-
lp:~sinzui/launchpad/cache-country-mirrors-0
Diff size: 21
Launchpad bug: https:/
Test command: ./bin/test -vv -t cache-country-
Pre-
Target release: 10.03
make cache-country-
-------
scripts/
I'm guessing it's writing in /tmp?
Rules
-----
* Switch from os.rename to shutils.move. From the api:
If the destination is on our current filesystem, then simply use rename.
Otherwise, copy src to the dst and then remove src.
QA
--
Run the script on the destination system and verify all is well.
Lint
----
Linting changed files:
scripts/
Test
----
The existing test is fine. We do not test filesystem corner cases like this.
Implementation
--------------
* scripts/
* switched from os.rename to shutils.move
| Brad Crittenden (bac) | # |
