Merge lp://staging/~sinzui/launchpad/buga-buga into lp://staging/launchpad

Fix some trivial bugs in Lp bugs.

    Launchpad bug:
        https://bugs.launchpad.net/bugs/136870
        https://bugs.launchpad.net/bugs/674546
        https://bugs.launchpad.net/bugs/670064
        https://bugs.launchpad.net/bugs/202136
        https://bugs.launchpad.net/bugs/297531
    Pre-implementation: deryck
    Test command: ./bin/test -vv \
      -t cve-linking \
      -t TestAssignmentNotification \
      -t stories/bug-release-management -t test_bugnomination

Bug #136870 [Link to bugs from lists of bugs in CVE pages]
    The title of linked bugs is not linked. User need to scroll to the
    related bugs portlet and find the bug number.

Bug #674546 ["See all hot bugs" link exists but lists cold bugs too]
    This link goes to a batched list of all open bug reports for the project,
    not just the hot ones.

Bug #670064 [Mail notification refers to "bug task" database schema]
    A "bug task for a public bug"? Is that something you need a Launchpad
    diploma to understand?

Bug #202136 [Nominating a bug for a series not a release]
    Distroseries were once named distroreleases, but that was inconsistent.
    The object name was fixed, but the links still mention a release. The
    use is actually asked to choose a series, not a release

Bug #297531 [+nominate UI needs a big rework]
    The title, heading, and form alignment issues have been fixed over the
    last two years, and the view is now restricted to bug supervisors and
    drivers. The page still talks of release when it means series, and the
    action should be Nominate or Target based on user privileges.

--------------------------------------------------------------------

RULES

Bug #136870 [Link to bugs from lists of bugs in CVE pages]
    * Link the bug title in the main content if the user has permission to
      view the bug

Bug #674546 ["See all hot bugs" link exists but lists cold bugs too]
    * As mpt suggests: change the text of the link to "Show all bugs by heat".

Bug #670064 [Mail notification refers to "bug task" database schema]
    * Change the sentence as mpt suggests
      <user.unique_displayname> has assigned this bug to you for <target>
    * ADDENDUM Removed else clause for missing creator. It is not possible
      to assign someone without knowing who did it. The logic appears to
      predate the use of transitionToAssignee()

Bug #202136 [Nominating a bug for a series not a release]
    * Change the text of the link to use 'series'.

Bug #297531 [+nominate UI needs a big rework]
    * Replace "release" with "series".
    * Change the action title to "Nominate" or "Target"

QA

Bug #136870 [Link to bugs from lists of bugs in CVE pages]
    * Visit https://bugs.launchpad.net/bugs/cve/2005-0406
    * Verify the heading of the related bugs link to the bug.

Bug #674546 ["See all hot bugs" link exists but lists cold bugs too]
    * Visit https://bugs.launchpad.net/launchpad
    * Verify the link under the hot bug listing reads "Show all bugs by heat".

Bug #670064 [Mail notification refers to "bug task" database schema]
    * Assign your self a bug.
    * Verify the email does not say you were assigned a bug task.

Bug #202136 [Nominating a bug for a series not a release]
    * Visit a bug you are a driver or bug supervisor for.
    * Verify the bug states target to/nominate for series

Bug #297531 [+nominate UI needs a big rework]
    * For a project you have permission to drive or supervise,
      Choose a bug that is not nominated for a series
    * Chose Nominate/Target to series
    * Verify the page talks of "series".
    * Verify the submit button reads Nominate or Target.

LINT

    lib/lp/bugs/browser/bug.py
    lib/lp/bugs/browser/bugnomination.py
    lib/lp/bugs/browser/tests/test_bugnomination.py
    lib/lp/bugs/mail/newbug.py
    lib/lp/bugs/mail/tests/test_bug_task_assignment.py
    lib/lp/bugs/stories/bug-release-management/30-nominate-bug-for-distrorelease.txt
    lib/lp/bugs/stories/bug-release-management/40-nominate-bug-for-productseries.txt
    lib/lp/bugs/stories/bug-release-management/60-defer-product-bug.txt
    lib/lp/bugs/stories/bug-release-management/xx-anonymous-bug-nomination.txt
    lib/lp/bugs/stories/cve/cve-linking.txt
    lib/lp/bugs/templates/bug-nominate-for-series.pt
    lib/lp/bugs/templates/bugnomination-edit.pt
    lib/lp/bugs/templates/bugtarget-bugs.pt
    lib/lp/bugs/templates/cve-index.pt

^ Lint hates a lot of these files. I can clean up the indentation and line
lengths before I submit.

IMPLEMENTATION

Bug #136870 [Link to bugs from lists of bugs in CVE pages]
    Added a permission check tot he template and linked the bug if the
    user has permission to view the bug
    lib/lp/bugs/stories/cve/cve-linking.txt
    lib/lp/bugs/templates/cve-index.pt

Bug #674546 ["See all hot bugs" link exists but lists cold bugs too]
    Updated the link text in
    lib/lp/bugs/templates/bugtarget-bugs.pt

Bug #670064 [Mail notification refers to "bug task" database schema]
    Revised the message and removed the event_creator condition.
    lib/lp/bugs/mail/newbug.py
    lib/lp/bugs/mail/tests/test_bug_task_assignment.py

Bug #202136 [Nominating a bug for a series not a release]
    Update link text and test.
    lib/lp/bugs/browser/bug.py
    lib/lp/bugs/stories/bug-release-management/xx-anonymous-bug-nomination.txt

Bug #297531 [+nominate UI needs a big rework]
    Updated the templates to use series instead of release. Hacked the view
    to change the action label and added a test that is more convincing than
    the existing stories.
    lib/lp/bugs/browser/tests/test_bugnomination.py
    lib/lp/bugs/browser/bugnomination.py
    lib/lp/bugs/stories/bug-release-management/30-nominate-bug-for-distrorelease.txt
    lib/lp/bugs/stories/bug-release-management/40-nominate-bug-for-productseries.txt
    lib/lp/bugs/stories/bug-release-management/60-defer-product-bug.txt
    lib/lp/bugs/templates/bug-nominate-for-series.pt
    lib/lp/bugs/templates/bugnomination-edit.pt