Merge lp://staging/~sinzui/juju-release-tools/win-client-64 into lp://staging/juju-release-tools

Proposed by Curtis Hovey
Status: Merged
Merged at revision: 333
Proposed branch: lp://staging/~sinzui/juju-release-tools/win-client-64
Merge into: lp://staging/juju-release-tools
Diff against target: 33 lines (+5/-4)
2 files modified (+3/-2)
tests/ (+2/-2)
To merge this branch: bzr merge lp://staging/~sinzui/juju-release-tools/win-client-64
Reviewer Review Type Date Requested Status
Seman (community) Approve
Review via email:

Description of the change

Build 64-bit windows clients.

Juju has crossed another threshold. The clients must also be 64-bit. Only the Win client was 32-bit. The branch updates the script to make 64-bit clients.

This change looks simple because our Golang makes cross OS and architecture compilations easy by exporting GOOS and GOARCH. You will see in the script that there are notes about how to setup any host to be ready for cross compilation.

Our helper function exports the GO* env vars, then calls "go install <PACKAGE>". One nuance about cross-compilation is that the binaries are stored in $GOPATH/bin/<GOOS_GOARCH>/ subdirs.

To post a comment you must log in.
Revision history for this message
Seman (sseman) wrote :

Thank you. Just make sure we don't have any external dependencies on the 32-bit Windows client.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches