Merge lp://staging/~sinzui/juju-release-tools/weekly-devel into lp://staging/juju-release-tools

Proposed by Curtis Hovey
Status: Merged
Merged at revision: 215
Proposed branch: lp://staging/~sinzui/juju-release-tools/weekly-devel
Merge into: lp://staging/juju-release-tools
Diff against target: 23 lines (+6/-0)
1 file modified
assemble-streams.bash (+6/-0)
To merge this branch: bzr merge lp://staging/~sinzui/juju-release-tools/weekly-devel
Reviewer Review Type Date Requested Status
Aaron Bentley (community) Approve
Review via email:

Description of the change

Ensure a devel product file exists when generating testing and weekly streams.

My hack to ensure testing streams could be repeatably created doesn't work for weekly streams because we cannot inject the heck between generation and publication.

While juju honours "path" in the streams index to find the product file we designate, generate-tools ignores it. The errant command assumes the devel file exists, and fails when it cannot read it. It should not want to read it because we didn't say we wanted to make devel streams. If it had chosen to read the real devel file to learn the support series and archs, it would have found them in the file we designated.

The hack is to copy the released product file to the devel product file *before* we call generate-tools. After we rewrite the index to match what we intend, the the file again to ensure if anything looks at this unwanted file, it will find what we designate. The diff shows this hack is following another hack to migrate coloned to dashed file names. This creation must die.

To post a comment you must log in.
Revision history for this message
Aaron Bentley (abentley) wrote :

Looks like a reasonable workaround.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches