Merge lp://staging/~sinzui/juju-release-tools/rewrite-devel into lp://staging/juju-release-tools

Proposed by Curtis Hovey
Status: Merged
Merged at revision: 208
Proposed branch: lp://staging/~sinzui/juju-release-tools/rewrite-devel
Merge into: lp://staging/juju-release-tools
Diff against target: 73 lines (+69/-0)
1 file modified (+69/-0)
To merge this branch: bzr merge lp://staging/~sinzui/juju-release-tools/rewrite-devel
Reviewer Review Type Date Requested Status
Aaron Bentley (community) Approve
Review via email:

Description of the change

Copy the released simple streams stanza to devel to do mixed juju testing.

I offer this script without tests as a means to unblock CI for a few weeks. I have already run this like so
    ../juju-release-tools/ -v ./index2.json released devel
then republished streams. All the substrate tests are passing.

I intend to update the two jobs that publish testing and weekly streams to run this between assemble-streams and publish-public-tools.

To post a comment you must log in.
Revision history for this message
Aaron Bentley (abentley) wrote :

Looks reasonable. A few nitpicks that needn't block landing:
- It would be nice to use a longer variable name for the opened file, rather than 'f'.
- It would be nice if the main function was compatible with the console_scripts entry point, i.e. no mandatory parameters.
- Maybe it should error if the to_key is already present? (Or does that break your workflow?)

review: Approve
209. By Curtis Hovey

Raise an error when the to_key is already defined.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches