Merge lp://staging/~sinzui/juju-release-tools/retry-swift into lp://staging/juju-release-tools

Proposed by Curtis Hovey
Status: Merged
Merged at revision: 191
Proposed branch: lp://staging/~sinzui/juju-release-tools/retry-swift
Merge into: lp://staging/juju-release-tools
Diff against target: 133 lines (+100/-1)
2 files modified
swift_sync.py (+17/-1)
tests/test_swift_sync.py (+83/-0)
To merge this branch: bzr merge lp://staging/~sinzui/juju-release-tools/retry-swift
Reviewer Review Type Date Requested Status
Martin Packman (community) Approve
Review via email: mp+261672@code.staging.launchpad.net

Description of the change

Retry swift uploads.

The publish-weekly job has failed two weeks in a row because of swift. Once for canonistack and once for hp. Modern swiftclient supports --retries, but the older version used by precise does not. This branch add a retry rule to make sync_swift more robust.

To post a comment you must log in.
Revision history for this message
Martin Packman (gz) wrote :

Looks good.

I presume we're fine with maybe retrying three times per file? Not sure how many swift calls we might reach if the api is just down or something, maybe enough to hit rate limits?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches