Merge lp://staging/~sinzui/juju-release-tools/rename-move into lp://staging/juju-release-tools
Proposed by
Curtis Hovey
| Status: | Rejected |
|---|---|
| Rejected by: | Curtis Hovey |
| Proposed branch: | lp://staging/~sinzui/juju-release-tools/rename-move |
| Merge into: | lp://staging/juju-release-tools |
| Diff against target: |
47 lines (+4/-4) 3 files modified
build_package.py (+1/-1) generate_agents.py (+2/-2) tests/test_build_package.py (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~sinzui/juju-release-tools/rename-move |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Juju Release Engineering | Pending | ||
|
Review via email:
|
|||
Description of the change
use shutil.move instead of os.rename
I saw several unit test failures when I ran the tests across mounted devices. This could be a problem for package building and streams which I often move to a separate device. I have always moved a common set of dirs to the extra device, which might explain why we haven't seen this issue. Since we don't always have sane file systems, switched to shutil.move.
To post a comment you must log in.
Unmerged revisions
- 312. By Curtis Hovey
-
shutil.move is safer than os.rename.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
