Merge lp://staging/~sinzui/juju-release-tools/lprelease-credentials into lp://staging/juju-release-tools

Proposed by Curtis Hovey
Status: Merged
Merged at revision: 201
Proposed branch: lp://staging/~sinzui/juju-release-tools/lprelease-credentials
Merge into: lp://staging/juju-release-tools
Diff against target: 143 lines (+95/-10)
2 files modified
lp_copy_packages.py (+13/-10)
tests/test_lp_copy_packages.py (+82/-0)
To merge this branch: bzr merge lp://staging/~sinzui/juju-release-tools/lprelease-credentials
Reviewer Review Type Date Requested Status
John George (community) Approve
Review via email: mp+267077@code.staging.launchpad.net

Description of the change

Added tests for lp_copy_packages.py

We need to extend lp_copy_packages.py to support credential and additional archives, but I don't want to change the behaviour without tests to the current features. This script originally came from my collection of Lp scripts, which don't have tests. I refactored the args for a few methods so that I could test them.

To post a comment you must log in.
Revision history for this message
John George (jog) wrote :

Thanks you.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches