juju-release-tools

Merge lp://staging/~sinzui/juju-release-tools/let-joyent-live into lp://staging/juju-release-tools

  1. let-joyent-live
  2. Merge into trunk
Proposed by Curtis Hovey
Status: Merged
Merged at revision: 119
Proposed branch: lp://staging/~sinzui/juju-release-tools/let-joyent-live
Merge into: lp://staging/juju-release-tools
Diff against target: 189 lines (+67/-40)
1 file modified
joyent.py (+67/-40)
To merge this branch: bzr merge lp://staging/~sinzui/juju-release-tools/let-joyent-live
Reviewer Review Type Date Requested Status
Aaron Bentley (community) Approve
Review via email: mp+243865@code.staging.launchpad.net

Description of the change

This branch sets the definition of an old machine in joyent to 12 hours.

I updated the argparser rules.
1. I extracted the parser to a separate function.
2. I added subparsers to manage the optional and required args.
3. I add --dry-run because I am paranoid. This change inflates the diff because I indented a lot of code that makes changes.

To post a comment you must log in.
Revision history for this message
Aaron Bentley (abentley) wrote :

This all looks reasonable, but I have some questions about delete-old-machine's arguments.

review: Needs Information
lp://staging/~sinzui/juju-release-tools/let-joyent-live updated
124. By Curtis Hovey

Make contact_email_address a manditory positional argument.
Added --old-age to set the number of hours that define old age.

Revision history for this message
Curtis Hovey (sinzui) wrote :

I made contact-email-address required. I added --old-age to set the hours of old-age.

./joyent.py delete-old-machines --help
usage: Query and manage joyent. delete-old-machines [-h] [-o OLD_AGE]
                                                    contact-mail-address

positional arguments:
  contact-mail-address Email address used in the Joyent support form

optional arguments:
  -h, --help show this help message and exit
  -o OLD_AGE, --old-age OLD_AGE
                        Set old machine age to n hours.

Revision history for this message
Aaron Bentley (abentley) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches