juju-release-tools

Merge lp://staging/~sinzui/juju-release-tools/jenkins-lpreleae into lp://staging/juju-release-tools

jenkins-lpreleae
Merge into trunk

Proposed by Curtis Hovey on 2015-07-31

Status:	Merged
Approved by:	Martin Packman on 2015-07-31
Approved revision:	199
Merged at revision:	199
Proposed branch:	lp://staging/~sinzui/juju-release-tools/jenkins-lpreleae
Merge into:	lp://staging/juju-release-tools
Diff against target:	60 lines (+10/-5) 1 file modified lprelease.py (+10/-5)
To merge this branch:	bzr merge lp://staging/~sinzui/juju-release-tools/jenkins-lpreleae
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Martin Packman (community)		2015-07-31	Approve on 2015-07-31
Review via email: mp+266570@code.staging.launchpad.net

Description of the change

Specify and alternate gpg command to sign upload files.

The last two releases I have done, I used lprelease.py on CI master. I placed my alternate gpg in my path to sign files. I prefer to specify the alternate gpg command to be clear what is signing. I added --gpgcmd to the script, which defaults to "gpg". The command is passed down from main -> add_release_files -> sign_file.

Revision history for this message

Martin Packman (gz) wrote on 2015-07-31:

Looks good!

Non-branch related musing, is there a better term than 'cmd' when you mean specifically a path to a binary, and absolutely not list of arguments?

review: Approve

Revision history for this message

Curtis Hovey (sinzui) wrote on 2015-07-31:

I have long wanted a better terms. I think command is correct in this case.
Command: an executable script or binary, may be the path to the specific executable.
Argument: a directive or sub-command passed to a command to do work
Option: a directive to change the behaviour of a command or argument.