Merge lp://staging/~sinzui/juju-release-tools/fix-generate-agents into lp://staging/juju-release-tools

Proposed by Curtis Hovey
Status: Merged
Merged at revision: 290
Proposed branch: lp://staging/~sinzui/juju-release-tools/fix-generate-agents
Merge into: lp://staging/juju-release-tools
Diff against target: 0 lines
To merge this branch: bzr merge lp://staging/~sinzui/juju-release-tools/fix-generate-agents
Reviewer Review Type Date Requested Status
Aaron Bentley (community) Approve
Review via email: mp+291197@code.staging.launchpad.net

Description of the change

Fix calls to writer.agent_path to be writer.path.

the call to release-juju-update-unsigned failed
   http://juju-ci.vapour.ws:8080/job/release-juju-update-unsigned/41/console
like so
  File "/var/lib/jenkins/juju-release-tools/generate_agents.py", line 135, in deb_to_agent
    final_agent_path = os.path.join(dest_dir, writer.agent_path)
AttributeError: 'StanzaWriter' object has no attribute 'agent_path'

This branch fixes the call. But non-tired eyes might disagree. I think I can write tests when I am not tired.

To post a comment you must log in.
Revision history for this message
Aaron Bentley (abentley) wrote :

Looks good. Sorry about that!

review: Approve
291. By Curtis Hovey

Added 2 of 3 needed tests.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches