Merge lp://staging/~sinzui/juju-release-tools/build-package-from-changes into lp://staging/juju-release-tools

Proposed by Curtis Hovey
Status: Merged
Merged at revision: 4
Proposed branch: lp://staging/~sinzui/juju-release-tools/build-package-from-changes
Merge into: lp://staging/juju-release-tools
Diff against target: 343 lines (+210/-62)
4 files modified
assemble-public-tools.bash (+1/-1)
build-package-with-dsc.bash (+190/-0)
make-package-with-tarball.bash (+8/-59)
make-source-packages.bash (+11/-2)
To merge this branch: bzr merge lp://staging/~sinzui/juju-release-tools/build-package-from-changes
Reviewer Review Type Date Requested Status
Aaron Bentley (community) Approve
Review via email: mp+220532@code.staging.launchpad.net

Description of the change

Add a dedicated script that can build binary packages from source packages. It can build on the local host, a remote host, or an ec2 instance.

assemble-public-tools.bash
    * This script only cares about juju-core debs, not the juju-local deb.
    * I kept the readlink code because I felt safer with using it.
make-package-with-tarball.bash
    * Removed knowledge of binary packages
    * Updated the args to accept -t to explicitly state we want testing packages
      Instead of implying the series. We always want to be clear about the series under test.
    * The leading ":" in getops was bogus; I wish getopts had told me that.
make-source-packages.bash
    * Renamed the file because I don't intend to teach it uploading any more.
    * Added the getopts -t (and removed the same bogus ":". It is passed to make-package-with-tarball.bash
build-package-with-dsc.bash
    * The new script that makes packages for the correct series and arch.
      It accept localhost, a remote host or ec2 information: eg
      build-package-with-dsc.bash localhost '' $dsc
      build-package-with-dsc.bash ubuntu@stilson-07 "$PPC_SSH_OPTIONS" $dsc
      build-package-with-dsc.bash m1.medium ami-81dee0e8 $dsc
    * I think the create_instance() function can be placed in a common lib or copied to run-unit-tests*
    * install_build_deps() evals a string of commands because I didn't want to write the commands twice...
      ...localhost needs an interactive shell since sudo is interactive
    * The [eval "set -- $ssh_options"] hack to place the ssh options in "$@" is used because
      it is the only way I found to let jenkins do complicated ssh maneuvers.
    * Is it maintainable?

To post a comment you must log in.
Revision history for this message
Aaron Bentley (abentley) wrote :

This looks sane to me. Some minor text issues, and a few things that could be clarified.

review: Approve
15. By Curtis Hovey

Fix spelling.

16. By Curtis Hovey

Replace EOT with simple sting since the script is simple now.

17. By Curtis Hovey

Fix spelling and add comments.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches