Merge lp://staging/~sinzui/juju-release-tools/build-package-from-changes into lp://staging/juju-release-tools
Status: | Merged |
---|---|
Merged at revision: | 4 |
Proposed branch: | lp://staging/~sinzui/juju-release-tools/build-package-from-changes |
Merge into: | lp://staging/juju-release-tools |
Diff against target: |
343 lines (+210/-62) 4 files modified
assemble-public-tools.bash (+1/-1) build-package-with-dsc.bash (+190/-0) make-package-with-tarball.bash (+8/-59) make-source-packages.bash (+11/-2) |
To merge this branch: | bzr merge lp://staging/~sinzui/juju-release-tools/build-package-from-changes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Aaron Bentley (community) | Approve | ||
Review via email: mp+220532@code.staging.launchpad.net |
Description of the change
Add a dedicated script that can build binary packages from source packages. It can build on the local host, a remote host, or an ec2 instance.
assemble-
* This script only cares about juju-core debs, not the juju-local deb.
* I kept the readlink code because I felt safer with using it.
make-package-
* Removed knowledge of binary packages
* Updated the args to accept -t to explicitly state we want testing packages
Instead of implying the series. We always want to be clear about the series under test.
* The leading ":" in getops was bogus; I wish getopts had told me that.
make-source-
* Renamed the file because I don't intend to teach it uploading any more.
* Added the getopts -t (and removed the same bogus ":". It is passed to make-package-
build-package-
* The new script that makes packages for the correct series and arch.
It accept localhost, a remote host or ec2 information: eg
build-
build-
build-
* I think the create_instance() function can be placed in a common lib or copied to run-unit-tests*
* install_
...localhost needs an interactive shell since sudo is interactive
* The [eval "set -- $ssh_options"] hack to place the ssh options in "$@" is used because
it is the only way I found to let jenkins do complicated ssh maneuvers.
* Is it maintainable?
This looks sane to me. Some minor text issues, and a few things that could be clarified.