Merge lp://staging/~sinzui/juju-release-tools/build-in-lxc-2 into lp://staging/juju-release-tools

Proposed by Curtis Hovey
Status: Merged
Merged at revision: 183
Proposed branch: lp://staging/~sinzui/juju-release-tools/build-in-lxc-2
Merge into: lp://staging/juju-release-tools
Diff against target: 231 lines (+80/-26)
2 files modified (+26/-15)
tests/ (+54/-11)
To merge this branch: bzr merge lp://staging/~sinzui/juju-release-tools/build-in-lxc-2
Reviewer Review Type Date Requested Status
Martin Packman (community) Approve
Review via email:

Description of the change

Add ppa support to

The current builders can have ppas, so we need to support this in lxc building too. I first tried apt-add-repository, but that added 35M's to the downloaded packages, and I was seeing apt async issues again. I decided to simply append the apt line to /etc/apt/sources.list. I also had to add --force-yes to the apt calls because the archive's key is not installed. Our golang and experimental PPAs have alternate packages for precise, so I tested this script like so: -v binary --ppa ppa:juju/golang ~/Downloads/juju-core_1.24-beta5-0ubuntu1~14.04.1~juju1.dsc ./ precise i386

I also addressed my concern about the lxc script doing cleanup. I moved the ownership and permission rules into python's flow control. I am very happy with the state of the workspace after a build completes (in both success and fail states).

To post a comment you must log in.
Revision history for this message
Martin Packman (gz) wrote :

Looks like a good step forward, provided you add some comments for the surprising aspects.

I don't get what was wrong with apt-add-repository, which would handle the key stuff and mean we didn't need --force-yes. I feel we should go back and work out what's up with command ordering later. So, a comment on the echo into sources.list and one on the ppa expansion seems reasonable.

review: Approve
188. By Curtis Hovey

Use a test USER.

189. By Curtis Hovey

Added comment about --force-yes.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches