Merge lp://staging/~sinzui/juju-release-tools/better-binaries into lp://staging/juju-release-tools

Proposed by Curtis Hovey
Status: Merged
Approved by: Martin Packman
Approved revision: 198
Merged at revision: 198
Proposed branch: lp://staging/~sinzui/juju-release-tools/better-binaries
Merge into: lp://staging/juju-release-tools
Diff against target: 33 lines (+2/-6)
2 files modified
build_package.py (+1/-3)
tests/test_build_package.py (+1/-3)
To merge this branch: bzr merge lp://staging/~sinzui/juju-release-tools/better-binaries
Reviewer Review Type Date Requested Status
Martin Packman (community) Approve
Review via email: mp+265704@code.staging.launchpad.net

Description of the change

Wait for package building output.

Aaron noticed that the subprocess call to make the binary packages never called wait(), which explains much of the async out put we see in successful builds. Since we don't care about pipes to the proc, we only want the return code, I switched to subprocess.call() to do what we want.

I had tried to also switch to use the ubuntu-cloud lxc template because precise supports it and machines on our private networks can access cloud-images (unlike the download lxc images). I abandoned the effort because I saw unmet deps in when setting of the build in the container. I think the cloud-images are too unstable for our needs.

To post a comment you must log in.
Revision history for this message
Martin Packman (gz) wrote :

Using communicate will always wait, but it doesn't do anything else useful if no pipes are being used. So, this change is good but isn't fixing a glaring error.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches