Merge lp://staging/~sinzui/juju-release-tools/bad-prometheus into lp://staging/juju-release-tools

Proposed by Curtis Hovey
Status: Merged
Approved by: Martin Packman
Approved revision: 334
Merged at revision: 334
Proposed branch: lp://staging/~sinzui/juju-release-tools/bad-prometheus
Merge into: lp://staging/juju-release-tools
Diff against target: 10 lines (+1/-0)
1 file modified
make-release-tarball.bash (+1/-0)
To merge this branch: bzr merge lp://staging/~sinzui/juju-release-tools/bad-prometheus
Reviewer Review Type Date Requested Status
Martin Packman (community) Approve
Review via email: mp+304381@code.staging.launchpad.net

Description of the change

Purge src/github.com/prometheus/procfs/fixtures from the release tarfile.

A run of
    lintian -I --pedantic
across the juju-core source package reveals
    E: juju-core source: source-contains-unsafe-symlink src/github.com/prometheus/procfs/fixtures/26231/exe

The problem is in the fixture dir which appears to be need by tests, not by the code. We will try to delete it.

To post a comment you must log in.
Revision history for this message
Martin Packman (gz) wrote :

Looks good. I wonder if we do want to report an issue of some kind upstream? Having an actual binary in the repo is somewhat dodgy.

review: Approve
Revision history for this message
Curtis Hovey (sinzui) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches