Merge lp://staging/~sinzui/juju-release-tools/azure-rc3 into lp://staging/juju-release-tools
| Status: | Merged |
|---|---|
| Merged at revision: | 312 |
| Proposed branch: | lp://staging/~sinzui/juju-release-tools/azure-rc3 |
| Merge into: | lp://staging/juju-release-tools |
| Diff against target: |
292 lines (+91/-38) 2 files modified
azure_publish_tools.py (+28/-11) tests/test_azure_publish_tools.py (+63/-27) |
| To merge this branch: | bzr merge lp://staging/~sinzui/juju-release-tools/azure-rc3 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Aaron Bentley (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
switch azure_publish_tools to use azure==2.0.0rc3
The feature-slave accidentally got the old azure lib, breaking the azure HA test. We need to switch everything
to the same library to avoid this maintenance burden
This branch updates azure_publish_tools to use the new azure storage lib (azure-storage (0.31.0)). This lib is automatically installed with azure==2.0.0rc3, but is not apart of that ARM project. This lib is an evolution
of version 0.8.0. Generic blobs are avoided in this new lib.
We use the BlockBlobService now and it manages the types, so a few methods loose some args.
It works with our existing account.
It suggests it wants an SharedAccessKey, but we do not require it...we are all powerful.
The public put_blob() method was removed.
put_block() does the initial put_blob().
The block ids must be caste to BlobBlock() which appears to manage state.
The optional BlobProperties were moved into a ContentSetting object
I have put, synced, and deleted several files and this
I added test coverage for delete_files()
My next branch will deal with the pip dep changes.
This looks good. It would be nice if the credentials.yaml could be used, but I am not sure whether it contains the right values.