Merge lp://staging/~sinzui/juju-release-tools/azure-mirror into lp://staging/juju-release-tools
Status: | Needs review |
---|---|
Proposed branch: | lp://staging/~sinzui/juju-release-tools/azure-mirror |
Merge into: | lp://staging/juju-release-tools |
Diff against target: |
110 lines (+26/-13) 2 files modified
generate_mirrors.py (+24/-11) tests/test_generate_mirrors.py (+2/-2) |
To merge this branch: | bzr merge lp://staging/~sinzui/juju-release-tools/azure-mirror |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Aaron Bentley (community) | Approve | ||
Review via email: mp+287088@code.staging.launchpad.net |
Description of the change
Use new azure endpoints in the agent mirror.
We were surprised to see that the azure-arm provider didn't find the agent mirror during the release of 2.0-beta1. We had configured the test to require the mirror. The new azure provider uses the same regions as defined at
http://
I assumed that the change to support azure-arm was to copy the new region-endpoint pairs from cloud-images to the templates we use to create agent mirrors. But I discovered that cloud-images does not have define pairs for the old endpoints.
I reviewed the code of 1.25 and see it does know about https:/
http://
1.25 is using the new endpoint to get images, and then uses the old endpoint to get agents.
Instead of adding new region-endpoint pairs, I updated the existing ones, then add the three new india regions. I want someone from Juju Core to also review this.
I suspect 1.25 works with old and new endpoints because the user's environments.yaml uses a matching region name. eg, users specify "US West". The new provider uses a different name for regions, but it knows to look for https:/
Unmerged revisions
- 277. By Curtis Hovey
-
Use the new azure endpoints to match the azure mirrors