Merge lp://staging/~sinzui/juju-ci-tools/win-status into lp://staging/juju-ci-tools
| Status: | Merged |
|---|---|
| Merged at revision: | 1524 |
| Proposed branch: | lp://staging/~sinzui/juju-ci-tools/win-status |
| Merge into: | lp://staging/juju-ci-tools |
| Diff against target: |
150 lines (+109/-6) 2 files modified
deploy_stack.py (+24/-6) tests/test_deploy_stack.py (+85/-0) |
| To merge this branch: | bzr merge lp://staging/~sinzui/juju-ci-tools/win-status |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Seman (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Check the application status message for the message.
This branch allows us to test windows charms in azure using juju 2.0. There were two issues seen before I started on this fix.
1. The tests failed because winrm raised an error. Instead of gracefully returning the methods continued until it reached an unbound variable. Martin and I agreed that the exception handling needs to log a warning about the error and return early.
2. Juju 1.25 and 2.0 support application status (workload status). We don't need any special libraries to read application status. I updated the juju 2.0 win charms to call status-set with the token. Status now shows the token for us to see.
I introduce a new function to check status and it is only checked in the windows case. Future branches can update all charms to set application status message and the script can always check token.
Thank you.