Merge lp://staging/~sinzui/juju-ci-tools/wait-for-upgrade into lp://staging/juju-ci-tools
Proposed by
Curtis Hovey
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 1783 | ||||
| Proposed branch: | lp://staging/~sinzui/juju-ci-tools/wait-for-upgrade | ||||
| Merge into: | lp://staging/juju-ci-tools | ||||
| Diff against target: |
61 lines (+27/-5) 2 files modified
deploy_stack.py (+17/-0) tests/test_deploy_stack.py (+10/-5) |
||||
| To merge this branch: | bzr merge lp://staging/~sinzui/juju-ci-tools/wait-for-upgrade | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Nicholas Skaggs (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Wait for list-models to work to know when the controller has upgraded.
Older jujus went dark for many minutes during an upgrade. We polled status for a time and when it worked, we started checking for the upgraded agent version. New juju does not go completely dark. status will works, and it will report the agents are upgraded, but the controller is *still* upgrading.
This branch treats list-models like status. After we see the agent are upgraded, we try list-models for a period of time. When the command works the script proceeds. Otherwise a timeout is raised.
Neither status nor show controller indicates that mongos collections are being upgraded. Our only clue is that we cannot work with any model.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This looks good, but I'd prefer we put a small comment in as to why we are doing the additional wait. A summary of what you've said above for future reference in the test. Namely, upgrades occur on agent and potentially db as well. Juju doesn't tell us when it's truly done. We are using list-models as the proxy for 'juju done'.