juju-ci-tools

Merge lp://staging/~sinzui/juju-ci-tools/token-wait into lp://staging/juju-ci-tools

  1. token-wait
  2. Merge into trunk
Proposed by Curtis Hovey
Status: Merged
Approved by: Martin Packman
Approved revision: 1527
Merged at revision: 1527
Proposed branch: lp://staging/~sinzui/juju-ci-tools/token-wait
Merge into: lp://staging/juju-ci-tools
Diff against target: 193 lines (+60/-20)
2 files modified
deploy_stack.py (+2/-2)
tests/test_deploy_stack.py (+58/-18)
To merge this branch: bzr merge lp://staging/~sinzui/juju-ci-tools/token-wait
Reviewer Review Type Date Requested Status
Martin Packman (community) Approve
Review via email: mp+301914@code.staging.launchpad.net

Description of the change

Wait for applications to be ready before checking the token.

The branch moved the call to wait_for_workloads() up to check_token(). The function does this first. We do see a delay in GCE when the charms under test supported it.

To post a comment you must log in.
Revision history for this message
Martin Packman (gz) wrote :

Looks good, thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches