Merge lp://staging/~sinzui/juju-ci-tools/run-instance-with-series into lp://staging/juju-ci-tools

Proposed by Curtis Hovey
Status: Merged
Merged at revision: 1093
Proposed branch: lp://staging/~sinzui/juju-ci-tools/run-instance-with-series
Merge into: lp://staging/juju-ci-tools
Diff against target: 100 lines (+32/-7)
3 files modified
deploy_stack.py (+1/-1)
substrate.py (+11/-2)
test_substrate.py (+20/-4)
To merge this branch: bzr merge lp://staging/~sinzui/juju-ci-tools/run-instance-with-series
Reviewer Review Type Date Requested Status
Martin Packman (community) Approve
Review via email: mp+271197@code.staging.launchpad.net

Description of the change

Create manual instances that match the series under test.

substrate.run_instances() only makes precise instances. The get_ami() is always passed "precise". This branch adds a series argument to run_instances(). There was only one call site, so I chose to make this a required argument. All the caller may have been given a series of None, we require a guard to assume precise. While every caller of boot_context should be passing series, we really don't know if every caller is explicitly passing series as they should.

To post a comment you must log in.
Revision history for this message
Martin Packman (gz) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches