Merge lp://staging/~sinzui/juju-ci-tools/remove-clean into lp://staging/juju-ci-tools

Proposed by Curtis Hovey
Status: Merged
Merged at revision: 1950
Proposed branch: lp://staging/~sinzui/juju-ci-tools/remove-clean
Merge into: lp://staging/juju-ci-tools
Diff against target: 159 lines (+4/-76)
2 files modified
jujuci.py (+3/-29)
tests/test_jujuci.py (+1/-47)
To merge this branch: bzr merge lp://staging/~sinzui/juju-ci-tools/remove-clean
Reviewer Review Type Date Requested Status
Seman (community) Approve
Review via email: mp+320885@code.staging.launchpad.net

Description of the change

Remove --clean from setup-workspace

This branch removed the --clean arg from jujuci.pu setup-workspace.
The clean operation does not work with Juju 2. The arg raise a fatal
error before the test starts on hosts with Juju 2 installed as the
system Juju.

Earlier this week I removed --clean from all jobs so that Juju 2 could
be set as the system Juju. Removing this arg helps prevent accidental
uses.

CERTIFY_UBUNTU_PACKAGES is left over from a previous removal

To post a comment you must log in.
Revision history for this message
Seman (sseman) wrote :

Thank you. I could not find other places that need to be removed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches