Merge lp://staging/~sinzui/juju-ci-tools/no-maas-logout into lp://staging/juju-ci-tools
Proposed by
Curtis Hovey
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 1860 | ||||
| Proposed branch: | lp://staging/~sinzui/juju-ci-tools/no-maas-logout | ||||
| Merge into: | lp://staging/juju-ci-tools | ||||
| Diff against target: |
76 lines (+5/-16) 2 files modified
substrate.py (+1/-1) tests/test_substrate.py (+4/-15) |
||||
| To merge this branch: | bzr merge lp://staging/~sinzui/juju-ci-tools/no-maas-logout | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Nicholas Skaggs (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Do not automatically logout of maas.
Mass jobs are failing under high parallelisation. They are failing to setup or teardown the maas because the proc was logged out. This is because there is only one mass cli, but there are many concurrent procs using it. Once setup/teadown fails, other jobs start to fail because the maas' subnets, spaces, fabrics, and interfaces are in the wrong state.
It is safe to login and relogin.
To post a comment you must log in.
Revision history for this message
| Nicholas Skaggs (nskaggs) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for this. I was reviewing the MAAS docs to see if not logging out is fine. I didn't find anything conclusive, but it does suggest and agree that logging in is fine.