Merge lp://staging/~sinzui/juju-ci-tools/gate-win into lp://staging/juju-ci-tools
Proposed by
Curtis Hovey
| Status: | Merged |
|---|---|
| Merged at revision: | 1508 |
| Proposed branch: | lp://staging/~sinzui/juju-ci-tools/gate-win |
| Merge into: | lp://staging/juju-ci-tools |
| Diff against target: |
246 lines (+128/-25) 4 files modified
gotesttarfile.py (+10/-5) gotestwin.py (+25/-17) tests/test_gotesttarfile.py (+25/-3) tests/test_gotestwin.py (+68/-0) |
| To merge this branch: | bzr merge lp://staging/~sinzui/juju-ci-tools/gate-win |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Martin Packman (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Run windows unit test from a local tarfile.
This branch gives us the option of running gated windows tests. There are two general changes.
1. We can pass a tarfile instead of a revision build number to gotestwin.py to test the revision we are gating. I added tests for this to ensure the old behaviour works.
2. I noticed that "go test -i ./..." wasn't called in gotesttarfile.py as it is in run-unit-test.
I have run this commands like this several times. I think we can recommend developers to test windows fixes like so:
../
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Couple of minor things to fix and some misc comments.