Merge lp://staging/~sinzui/juju-ci-tools/default-storage into lp://staging/juju-ci-tools
Proposed by
Curtis Hovey
| Status: | Merged |
|---|---|
| Merged at revision: | 1541 |
| Proposed branch: | lp://staging/~sinzui/juju-ci-tools/default-storage |
| Merge into: | lp://staging/juju-ci-tools |
| Diff against target: |
239 lines (+101/-46) 2 files modified
assess_storage.py (+53/-42) tests/test_assess_storage.py (+48/-4) |
| To merge this branch: | bzr merge lp://staging/~sinzui/juju-ci-tools/default-storage |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Christopher Lee (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Added aws defaults to the expected storage pool.
The storage test is failing because it juju now correctly includes aws
default storage options. This branch add a rule to check the type of
deployment to set expectations.
I wasn't sure of the scope of the problem when I started this branch.
I fixed some lint regarding casing. Then extracted check_storage_list
to help me see what was happening in the test. I thought I would
extend the helper to check the pool, but it wasn't necessary.
The top of the module and the start of assess_storage get the added
knowledge pass on aws.
To post a comment you must log in.
Revision history for this message
| Curtis Hovey (sinzui) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The addition of check_storage_list is very good.
Have 1 question re: list order
Have 1 suggestion re: using existing api method.
Looking good otherwise.