Code review comment for lp://staging/~sinzui/ci-director/logrotate

Revision history for this message
Aaron Bentley (abentley) wrote :

Approved pending the changes we discussed on IRC:
<abentley> sinzui: I frequently run ci-director from the commandline. With this change, that won't produce any output. Could there be a way to get output back for this case, or did you decide it's not worth it?
<sinzui> abentley, Sorry. I was tailing the log.
<sinzui> abentley, I can restore the stream handler. We can have both
<abentley> sinzui: Thanks.
<abentley> sinzui: I tend to avoid having main accept arguments, because it's incompatible with the setuptools entry_points mechanism. But in this case, that doesn't matter.
<sinzui> abentley, yeah. I resisted the args to main()
 abentley, I could switch to argv=None....
<sinzui> or extract the args parser to another function manybe
<abentley> I think argv=None is simple and does the job.

review: Approve

« Back to merge proposal