charmworld

Merge lp://staging/~sinzui/charmworld/release-port into lp://staging/~juju-jitsu/charmworld/trunk

  1. release-port
  2. Merge into trunk
Proposed by Curtis Hovey
Status: Merged
Approved by: Curtis Hovey
Approved revision: 192
Merged at revision: 197
Proposed branch: lp://staging/~sinzui/charmworld/release-port
Merge into: lp://staging/~juju-jitsu/charmworld/trunk
Diff against target: 42 lines (+19/-11)
2 files modified
scripts/clear-cache (+0/-10)
scripts/stop (+19/-1)
To merge this branch: bzr merge lp://staging/~sinzui/charmworld/release-port
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Richard Harding Pending
Review via email: mp+158965@code.staging.launchpad.net

This proposal supersedes a proposal from 2013-04-11.

Commit message

Ensure charmworld releases it's port when stopped.

Description of the change

Ensure charmworld releases it's port when stopped.

RULES

    * Juju depolys often see errors when mongodb joins because the port was
      not released before start was called again.
    * Stop must ensure the port is released before calling scripts can
      proceed with their actions and restart.

    ADDENDUM
    * Removed the nginx cache script sicne it is not needed.

QA

   * Verified that the port clears normally as we always assumed would happen.
   * Verified that the port clears if ther eis no pid file (and that is not
     and error condition)
   * Verified a slow termination will clear after a few seconds.
   * Verified if the port does not clear in 5 minutes, the script exits
     any and and explains the badness.

To post a comment you must log in.
Revision history for this message
Richard Harding (rharding) wrote : Posted in a previous version of this proposal

LGTM I'm going to assume your sed work is tested out and works well.

review: Approve
Revision history for this message
Charmworld Lander (charmworld-lander) wrote : Posted in a previous version of this proposal

The Jenkins job https://jenkins.qa.ubuntu.com/job/charmworld-merger-trunk/148/console reported an error when processing this lp:~sinzui/charmworld/release-port branch.
Not merging it.

Revision history for this message
Richard Harding (rharding) wrote : Posted in a previous version of this proposal

Re-approving. I don't see any failing in the jenkins. Not sure why it didn't go through. Try again.

review: Approve
Revision history for this message
Charmworld Lander (charmworld-lander) wrote : Posted in a previous version of this proposal

The Jenkins job https://jenkins.qa.ubuntu.com/job/charmworld-merger-trunk/211/console reported an error when processing this lp:~sinzui/charmworld/release-port branch.
Not merging it.

Revision history for this message
Charmworld Lander (charmworld-lander) wrote : Posted in a previous version of this proposal

The Jenkins job https://jenkins.qa.ubuntu.com/job/charmworld-merger-trunk/226/console reported an error when processing this lp:~sinzui/charmworld/release-port branch.
Not merging it.

Revision history for this message
Charmworld Lander (charmworld-lander) wrote : Posted in a previous version of this proposal

The Jenkins job https://jenkins.qa.ubuntu.com/job/charmworld-merger-trunk/227/console reported an error when processing this lp:~sinzui/charmworld/release-port branch.
Not merging it.

Revision history for this message
Charmworld Lander (charmworld-lander) wrote : Posted in a previous version of this proposal

The Jenkins job https://jenkins.qa.ubuntu.com/job/charmworld-merger-trunk/232/console reported an error when processing this lp:~sinzui/charmworld/release-port branch.
Not merging it.

Revision history for this message
Charmworld Lander (charmworld-lander) wrote : Posted in a previous version of this proposal

The Jenkins job https://jenkins.qa.ubuntu.com/job/charmworld-merger-trunk/233/console reported an error when processing this lp:~sinzui/charmworld/release-port branch.
Not merging it.

Revision history for this message
Charmworld Lander (charmworld-lander) wrote : Posted in a previous version of this proposal

The Jenkins job https://jenkins.qa.ubuntu.com/job/charmworld-merger-trunk/234/console reported an error when processing this lp:~sinzui/charmworld/release-port branch.
Not merging it.

Revision history for this message
Charmworld Lander (charmworld-lander) wrote : Posted in a previous version of this proposal

The Jenkins job https://jenkins.qa.ubuntu.com/job/charmworld-merger-trunk/235/console reported an error when processing this lp:~sinzui/charmworld/release-port branch.
Not merging it.

Revision history for this message
Charmworld Lander (charmworld-lander) wrote : Posted in a previous version of this proposal

The Jenkins job https://jenkins.qa.ubuntu.com/job/charmworld-merger-trunk/235/console reported an error when processing this lp:~sinzui/charmworld/release-port branch.
Not merging it.

Revision history for this message
Curtis Hovey (sinzui) wrote : Posted in a previous version of this proposal

tarmac and jenkins are mis-communicating. Not that comments 10 and 11 point to the same log. Comment 11 happened a few minutes after I approved the review, but matsubara says that jenkins was actually doing a different build: https://jenkins.qa.ubuntu.com/job/charmworld-merger-trunk/236/console show the build was successful.

Revision history for this message
Charmworld Lander (charmworld-lander) wrote : Posted in a previous version of this proposal

The Jenkins job https://jenkins.qa.ubuntu.com/job/charmworld-merger-trunk/237/console reported an error when processing this lp:~sinzui/charmworld/release-port branch.
Not merging it.

Revision history for this message
Curtis Hovey (sinzui) wrote :

Re-approving Rick's approval. This new MP is an attempt to unstick tarmac.

review: Approve (code)
Revision history for this message
Charmworld Lander (charmworld-lander) wrote :

No commit message specified.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches