Merge lp://staging/~sinzui/charmworld/modern-py into lp://staging/~juju-jitsu/charmworld/trunk
Proposed by
Curtis Hovey
| Status: | Merged |
|---|---|
| Merged at revision: | 352 |
| Proposed branch: | lp://staging/~sinzui/charmworld/modern-py |
| Merge into: | lp://staging/~juju-jitsu/charmworld/trunk |
| Diff against target: |
41 lines (+9/-12) 1 file modified
charmworld/views/misc.py (+9/-12) |
| To merge this branch: | bzr merge lp://staging/~sinzui/charmworld/modern-py |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Aaron Bentley (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Modernise chartmers() and document what it really does.
Description of the change
Modernise chartmers() and document what it really does.
While adding API3, I stumbled reading the charmer() method. The code is written like py2.3. I uses the deprecated cmp() builtin, and it does work that defaultdict and soted do. I did not understand why the first element was popped. I then read the comment and knew it was a lie. charmworld does not know all the committers to charms. The listing is really about how many charms people own, except for the charmers team which is assumed to own most charms.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This is shorter and clearer, so I like it. I don't know if there's value in py3 compatibility per se. If it were somewhere other than report code, I'd ask about tests.