Code review comment for lp://staging/~sinzui/charmworld/api3-search

Revision history for this message
Brad Crittenden (bac) wrote :

Just curious, did you mean to use "_" as a dummy assignment var? I picked that up in JS but we've decide against it in Python since it can clash with real uses.

As we discussed on IRC, I think adding a 'doctype' to the metadata makes sense.

It's a shame you have to go through that non-sense to figure out if it is a bundle for looking for 'basket'.

The rest looks good. Thanks.

review: Approve

« Back to merge proposal