Merge lp://staging/~sinzui/charms/precise/charmworld/icon-and-category into lp://staging/~juju-jitsu/charms/precise/charmworld/trunk
Proposed by
Curtis Hovey
| Status: | Merged |
|---|---|
| Approved by: | Curtis Hovey |
| Approved revision: | 70 |
| Merged at revision: | 68 |
| Proposed branch: | lp://staging/~sinzui/charms/precise/charmworld/icon-and-category |
| Merge into: | lp://staging/~juju-jitsu/charms/precise/charmworld/trunk |
| Diff against target: |
458 lines (+431/-2) 4 files modified
copyright (+17/-0) icon.svg (+407/-0) metadata.yaml (+6/-1) revision (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~sinzui/charms/precise/charmworld/icon-and-category |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Aaron Bentley (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Add an icon and fix the category.
Description of the change
This branch updates the charmworld charm to quiet charm proof
RULES
* Add an icon.
I didn't like the colourless svg I was given. I gave it the ubuntu background colour to follow the
juju-gui example.
http://
* Fix the categories metadata key.
Should be a list of one: ["applications"]
* Add a copyright file.
The charms is GPL like all the charm related work.
Marco contributed before canonical employment.
QA
* run
charm proof
* Verify the charm has no errors or warnings.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
We should consider whether using an svgz would be helpfully opaque, since the text of an SVG file isn't typically useful.