Merge lp://staging/~sinzui/bzr-gtk/broken-labels into lp://staging/bzr-gtk
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Jelmer Vernooij | ||||
| Approved revision: | 783 | ||||
| Merged at revision: | 785 | ||||
| Proposed branch: | lp://staging/~sinzui/bzr-gtk/broken-labels | ||||
| Merge into: | lp://staging/bzr-gtk | ||||
| Diff against target: |
42 lines (+4/-3) 2 files modified
annotate/gannotate.py (+3/-2) merge.py (+1/-1) |
||||
| To merge this branch: | bzr merge lp://staging/~sinzui/bzr-gtk/broken-labels | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jelmer Vernooij (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Fix button mnemonics.
gannotate find shows the find bar. The bar has a "_Next" and "_Previous"
button. The mnemonic in the label was not converted into an accelerator.
bzr merge also has a "_Merge" button.
-------
RULES
* Pass the use_underline=True property kwarg to set the property
to scan for mnemonics.
* ADDENDUM, "_Merge" is not translatable.
QA
* Run BZR_PLUGINS_
* Choose find and enter "merge"
* Press Alt.
* Verify the underscore appears under N and P.
* Pressing Alt+N find the next match
* Run BZR_PLUGINS_
* Press Alt.
* Verify the underscore appears under M.
IMPLEMENTATION
I noticed the underscores while working on another branch. I searched the
tree and found 3 cases where Gtk.Button() was called with a label with
an underscore without use_underline=True.
| Jelmer Vernooij (jelmer) | # |
