Ubuntu
landscape-client package

Merge ~simpoir/ubuntu/+source/landscape-client:beyond_19.04 into ubuntu/+source/landscape-client:ubuntu/devel

  1. Git
  2. lp:~simpoir/ubuntu/+source/landscape-client
  3. beyond_19.04
  4. Merge into ubuntu/devel
Proposed by Simon Poirier
Status: Merged
Approved by: Andreas Hasenack
Approved revision: ba2b91dfd960345a2bcdae49cd034f6e579a2287
Merged at revision: ba2b91dfd960345a2bcdae49cd034f6e579a2287
Proposed branch: ~simpoir/ubuntu/+source/landscape-client:beyond_19.04
Merge into: ubuntu/+source/landscape-client:ubuntu/devel
Diff against target: 377 lines (+326/-1)
6 files modified
debian/changelog (+12/-0)
debian/landscape-client.init (+2/-1)
debian/landscape-client.postinst (+3/-0)
debian/patches/product-name-vminfo-1828217.patch (+49/-0)
debian/patches/series (+2/-0)
debian/patches/stagger-launch-1788518.patch (+258/-0)
Reviewer Review Type Date Requested Status
Andreas Hasenack (community) Approve
Canonical Server Pending
git-ubuntu developers Pending
Review via email: mp+368945@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Thanks, comments inline

review: Needs Fixing
Revision history for this message
Simon Poirier (simpoir) :
Revision history for this message
Andreas Hasenack (ahasenack) :
Revision history for this message
Simon Poirier (simpoir) :
Revision history for this message
Andreas Hasenack (ahasenack) :
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

You are still patching a maintainer script (postinst)

review: Needs Fixing
Revision history for this message
Simon Poirier (simpoir) wrote :

I've "unpatchified" that change.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

LGTM, +1

Do you want immediate sponsoring of this?

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Sponsoring ba2b91dfd960345a2bcdae49cd034f6e579a2287

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Tagged and uploaded:

$ git push pkg upload/18.01-0ubuntu9
Enumerating objects: 32, done.
Counting objects: 100% (32/32), done.
Delta compression using up to 2 threads
Compressing objects: 100% (25/25), done.
Writing objects: 100% (25/25), 6.95 KiB | 711.00 KiB/s, done.
Total 25 (delta 17), reused 0 (delta 0)
To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/landscape-client
 * [new tag] upload/18.01-0ubuntu9 -> upload/18.01-0ubuntu9

$ dput ubuntu ../landscape-client_18.01-0ubuntu9_source.changes
Checking signature on .changes
gpg: ../landscape-client_18.01-0ubuntu9_source.changes: Valid signature from AC983EB5BF6BCBA9
Checking signature on .dsc
gpg: ../landscape-client_18.01-0ubuntu9.dsc: Valid signature from AC983EB5BF6BCBA9
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading landscape-client_18.01-0ubuntu9.dsc: done.
  Uploading landscape-client_18.01-0ubuntu9.debian.tar.xz: done.
  Uploading landscape-client_18.01-0ubuntu9_source.buildinfo: done.
  Uploading landscape-client_18.01-0ubuntu9_source.changes: done.
Successfully uploaded packages.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches