Ubuntu
landscape-client package

Merge ~simpoir/ubuntu/+source/landscape-client:cosmic-landscape-client-backports-1788219 into ubuntu/+source/landscape-client:ubuntu/cosmic-devel

  1. Git
  2. lp:~simpoir/ubuntu/+source/landscape-client
  3. cosmic-landscape-client-backports-1788219
  4. Merge into ubuntu/cosmic-devel
Proposed by Simon Poirier
Status: Merged
Approved by: Andreas Hasenack
Approved revision: f74c019f215ade397dfd9c5ead31b7a6cc5089ce
Merged at revision: f74c019f215ade397dfd9c5ead31b7a6cc5089ce
Proposed branch: ~simpoir/ubuntu/+source/landscape-client:cosmic-landscape-client-backports-1788219
Merge into: ubuntu/+source/landscape-client:ubuntu/cosmic-devel
Diff against target: 549 lines (+503/-0)
7 files modified
debian/changelog (+16/-0)
debian/patches/1616116-resync-loop.patch (+142/-0)
debian/patches/nutanix-kvm.patch (+18/-0)
debian/patches/post-upgrade-reboot.patch (+132/-0)
debian/patches/release-upgrade-success.patch (+23/-0)
debian/patches/series (+5/-0)
debian/patches/unicode-tags-script.patch (+167/-0)
Reviewer Review Type Date Requested Status
Andreas Hasenack (community) Approve
git-ubuntu developers Pending
Review via email: mp+358162@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) :
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Bug #1699179 is mentioned in the changelog, with two patches. But it's already marked as "fix released" for bionic in 18.01-0ubuntu1:
...
    - Check if ubuntu-release-upgrader is running before apt-update (LP: #1699179)...

What we have here are further fixes for the same issue? Should that bug be reopened for bionic perhaps?

review: Needs Fixing
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Sorry, I meant "needs information"

review: Needs Information
Revision history for this message
Simon Poirier (simpoir) wrote :

> What we have here are further fixes for the same issue? Should that bug be
> reopened for bionic perhaps?

Not really. This specific one was already in. However, upgrades were still failing because of #1670291.

I'll unlink 1699179 from the changelog of this MP, but it still affects xenial/trusty, where the 3 patches can be tested by a successful upgrade.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Could you please mention LP: #1670291 in d/changelog for debian/patches/release-upgrade-success.patch, like you did for disco?

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Looks good, +1

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Tag updated and uploaded.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches