Landscape Client

Merge lp://staging/~simpoir/landscape-client/bug_1531150_package_reporter_proxy into lp://staging/~landscape/landscape-client/trunk

  1. bug_1531150_package_reporter_proxy
  2. Merge into trunk
Proposed by Simon Poirier
Status: Merged
Approved by: Simon Poirier
Approved revision: 917
Merged at revision: 919
Proposed branch: lp://staging/~simpoir/landscape-client/bug_1531150_package_reporter_proxy
Merge into: lp://staging/~landscape/landscape-client/trunk
Diff against target: 247 lines (+121/-8)
5 files modified
apt-update/apt-update.c (+19/-1)
landscape/lib/fetch.py (+5/-1)
landscape/lib/tests/test_fetch.py (+8/-0)
landscape/package/reporter.py (+17/-2)
landscape/package/tests/test_reporter.py (+72/-4)
To merge this branch: bzr merge lp://staging/~simpoir/landscape-client/bug_1531150_package_reporter_proxy
Reviewer Review Type Date Requested Status
Adam Collard (community) Approve
🤖 Landscape Builder test results Approve
Eric Snow (community) Approve
Review via email: mp+301774@code.staging.launchpad.net

Commit message

Add proxy handling to package reporter.

Description of the change

Add proxy handling to package reporter.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 916
Branch: lp:~simpoir/landscape-client/bug_1531150_package_reporter_proxy
Jenkins: https://ci.lscape.net/job/latch-test/5865/

review: Approve (test results)
Revision history for this message
Eric Snow (ericsnowcurrently) wrote :

Aside from a couple small issues and a few questions, LGTM.

Just to make sure I understand, currently there are 2 separate situations where package-reporter ignores the landscape-configured proxy values: the apt-update helper and fetching the hash-id-database. Are there other situations where package-reporter is handling the proxy correctly?

Also, you're solving the apt-update problem by passing the proxy settings from the config into the env vars under which the apt-update helper runs. For the fetch issue, you're passing the proxy in to fetch() and on to curl. Is all that right?

review: Needs Information
Revision history for this message
Simon Poirier (simpoir) :
lp://staging/~simpoir/landscape-client/bug_1531150_package_reporter_proxy updated
917. By Simon Poirier

address some comments from ericsnow

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 917
Branch: lp:~simpoir/landscape-client/bug_1531150_package_reporter_proxy
Jenkins: https://ci.lscape.net/job/latch-test/6189/

review: Approve (test results)
Revision history for this message
Eric Snow (ericsnowcurrently) wrote :

+1

review: Approve
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 917
Branch: lp:~simpoir/landscape-client/bug_1531150_package_reporter_proxy
Jenkins: https://ci.lscape.net/job/latch-test/6578/

review: Approve (test results)
Revision history for this message
Adam Collard (adam-collard) :
review: Needs Information
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 917
Branch: lp:~simpoir/landscape-client/bug_1531150_package_reporter_proxy
Jenkins: https://ci.lscape.net/job/latch-test/7166/

review: Approve (test results)
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 917
Branch: lp:~simpoir/landscape-client/bug_1531150_package_reporter_proxy
Jenkins: https://ci.lscape.net/job/latch-test/7455/

review: Approve (test results)
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 917
Branch: lp:~simpoir/landscape-client/bug_1531150_package_reporter_proxy
Jenkins: https://ci.lscape.net/job/latch-test/7832/

review: Approve (test results)
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 917
Branch: lp:~simpoir/landscape-client/bug_1531150_package_reporter_proxy
Jenkins: https://ci.lscape.net/job/latch-test/7845/

review: Approve (test results)
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 917
Branch: lp:~simpoir/landscape-client/bug_1531150_package_reporter_proxy
Jenkins: https://ci.lscape.net/job/latch-test/7890/

review: Approve (test results)
Revision history for this message
Simon Poirier (simpoir) :
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 917
Branch: lp:~simpoir/landscape-client/bug_1531150_package_reporter_proxy
Jenkins: https://ci.lscape.net/job/latch-test/7929/

review: Approve (test results)
Revision history for this message
Adam Collard (adam-collard) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: